Skip to content

Commit 6ee7749

Browse files
authored
SWI-8402 Add New StartStream Attributes (#78)
1 parent 2e0e73f commit 6ee7749

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

models/bxml/verbs/StartStream.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ export interface StartStreamAttributes {
66
mode?: string;
77
tracks?: string;
88
destination?: string;
9+
destinationUsername?: string;
10+
destinationPassword?: string;
911
streamEventUrl?: string;
1012
streamEventMethod?: string;
1113
username?: string;

tests/unit/models/bxml/verbs/StartStream.test.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ describe('StartStream', () => {
88
mode: 'unidirectional',
99
tracks: 'inbound',
1010
destination: 'https://initial.com',
11+
destinationUsername: 'initialDestUsername',
12+
destinationPassword: 'initialDestPassword',
1113
streamEventUrl: 'https://initial.com',
1214
streamEventMethod: 'POST',
1315
username: 'initialUsername',
@@ -19,7 +21,7 @@ describe('StartStream', () => {
1921

2022
test('should create a StartStream Verb', () => {
2123
const startStream = new StartStream(attributes);
22-
const expected = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"/>';
24+
const expected = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" destinationUsername="initialDestUsername" destinationPassword="initialDestPassword" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"/>';
2325

2426
expect(startStream).toBeInstanceOf(StartStream);
2527
expect(startStream).toBeInstanceOf(Verb);
@@ -28,9 +30,9 @@ describe('StartStream', () => {
2830

2931
test('should create a StartStream Verb with nested StreamParams', () => {
3032
let startStream = new StartStream(attributes, streamParam1);
31-
const expected = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/></StartStream>';
32-
const expectedSingle = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/></StartStream>';
33-
const expectedMultiple = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/></StartStream>';
33+
const expected = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" destinationUsername="initialDestUsername" destinationPassword="initialDestPassword" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/></StartStream>';
34+
const expectedSingle = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" destinationUsername="initialDestUsername" destinationPassword="initialDestPassword" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/></StartStream>';
35+
const expectedMultiple = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" destinationUsername="initialDestUsername" destinationPassword="initialDestPassword" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/><StreamParam name="streamParamName1" value="streamParamValue1"/><StreamParam name="streamParamName2" value="streamParamValue2"/></StartStream>';
3436

3537
expect(startStream).toBeInstanceOf(StartStream);
3638
expect(startStream).toBeInstanceOf(Verb);
@@ -45,7 +47,7 @@ describe('StartStream', () => {
4547

4648
test('should test the addStreamParams method when no verbs are initially nested', () => {
4749
const startStream = new StartStream(attributes);
48-
const expected = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/></StartStream>';
50+
const expected = '<StartStream name="initialName" mode="unidirectional" tracks="inbound" destination="https://initial.com" destinationUsername="initialDestUsername" destinationPassword="initialDestPassword" streamEventUrl="https://initial.com" streamEventMethod="POST" username="initialUsername" password="initialPassword"><StreamParam name="streamParamName1" value="streamParamValue1"/></StartStream>';
4951

5052
startStream.addStreamParams(streamParam1);
5153
expect(startStream.toBxml()).toBe(expected);

0 commit comments

Comments
 (0)