Merge pull request #18 from BaguettePHP/feature/pgescape-identifier

Fix PgIdentifier::escape()

Author: zonuexe

src/Type/PgIdentifier.php

@@ -94,9 +94,11 @@ public function escapeValue($pdo, $key, $type, $value, &$bind_values)
     /**
      * @phpstan-param string $value
      * @phpstan-return non-empty-string
+     * @see https://github.com/postgres/postgres/blob/REL9_0_STABLE/src/interfaces/libpq/fe-exec.c#L3165-L3169
+     * @see https://github.com/postgres/postgres/blob/REL_15_STABLE/src/interfaces/libpq/fe-exec.c#L4216-L4220
      */
     public function quote($value)
     {
-        return '"' . $value . '"';
+        return '"' . \strtr($value, ['"' => '""']) . '"';
     }
 }

tests/Type/PgIdentifierTest.php

@@ -41,6 +41,11 @@ public function escapeValuesProvider()
     {
         return [
             ['' , '@column', '""'],
+            ['abc' , '@column', '"abc"'],
+            ['ABC' , '@column', '"ABC"'],
+            ['ABC\\ABC\'' , '@column', '"ABC\\ABC\'"'],
+            ['ABC"ABC' , '@column', '"ABC""ABC"'],
+            ['ABC"""ABC' , '@column', '"ABC""""""ABC"'],
             [['foo'] , '@column[]', '"foo"'],
             [['foo','bar'] , '@column[]', '"foo","bar"'],
             [['foo' => 'bar'] , '@column[]', 'foo AS "bar"'],