Agnostic toolset for VS project + std link issue with MSVC 17.2+ #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You might want to keep the current behavior but allow overriding based on an msbuild prop? (Or at least continue to have some default?) |
CedricGuillemet
changed the title
bghgary
reviewed
May 31, 2023
Modules/@babylonjs/react-native-windows/windows/BabylonReactNative/BabylonReactNative.vcxproj
Outdated
Show resolved
Hide resolved
…tive/BabylonReactNative.vcxproj Co-authored-by: Gary Hsu <bghgary@users.noreply.github.com>
…t/BabylonReactNative-1 into agnosticVSVersion
bghgary
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default toolset is v142. it can be overriden with
BabylonReactNativeToolsetproperty