Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naming convention for parsing from File or snippet #12791

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Fix naming convention for parsing from File or snippet #12791

merged 2 commits into from
Jul 25, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Jul 25, 2022

No description provided.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12791/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12791/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12791/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12791/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12791/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12791/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12791/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12791/merge#BCU1XR#0

deltakosh
deltakosh approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@deltakosh deltakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome in the modern world ;)

@deltakosh deltakosh merged commit 306c23c into BabylonJS:master Jul 25, 2022
@RaananW RaananW deleted the namingRight branch July 25, 2022 19:39
RaananW added a commit that referenced this pull request Dec 9, 2022
@RaananW
Fix naming convention for parsing from File or snippet (#12791)
f93ce6a 
* Fix naming convention

* formatting

Former-commit-id: d96b49dd964fdc3e941a75b0246b3ac33f2de5c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaananW @deltakosh