Add support for more depth stencil formats.

[kircher1]

This requires some rework of the logic in ThinEngine._createDepthStencilTexture, but it should be non-breaking. A similar change was made to extend MultiRenderTarget's depth-stencil texture handling too.

I've also added visualization tests to exercise the createDepthStencilTexture code path.

[kircher1]

I've been struggling to get the visualization tests working and passing locally (not just the new tests, but also existing tests). And not just for this branch, master too. So, still trying to figure that out.

[azure-pipelines]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

[azure-pipelines]

Snapshot stored with reference name:
refs/pull/12675/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12675/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12675/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12675/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12675/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12675/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12675/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12675/merge#BCU1XR#0

[azure-pipelines]

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12675/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

[kircher1]

Need to fix some GL1 related issues.

[Popov72]

Good job!

You will also have to update WebGPU. It's in Engines/WebGPU/Extensions/engine.renderTarget.ts, the _createDepthStencilTexture function.

[kircher1]

You will also have to update WebGPU. It's in Engines/WebGPU/Extensions/engine.renderTarget.ts, the _createDepthStencilTexture function.

@Popov72, from the looks of it, the WebGPU implementation already handles the various depth stencil formats. Correct me if I'm wrong and I will make the necessary updates.

[azure-pipelines]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

[azure-pipelines]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

[azure-pipelines]

Snapshot stored with reference name:
refs/pull/12675/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12675/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12675/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12675/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12675/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12675/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12675/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12675/merge#BCU1XR#0

[Popov72]

I think line 83 of the file I pointed above should be replaced by:

depthTextureFormat: options.depthTextureFormat ?? options.generateStencil ? Constants.TEXTUREFORMAT_DEPTH24_STENCIL8 : Constants.TEXTUREFORMAT_DEPTH32_FLOAT,

[sebavan]

LGTM as soon as @Popov72 concerns have been addressed

[kircher1]

TEXTUREFORMAT_DEPTH24_STENCIL8 

@Popov72, does the spread operator for ...options on line 84 handle overwriting depthTextureFormat?

 const internalOptions = {
        bilinearFiltering: false,
        comparisonFunction: 0,
        generateStencil: false,
        samples: 1,
        depthTextureFormat: options.generateStencil ? Constants.TEXTUREFORMAT_DEPTH24_STENCIL8 : Constants.TEXTUREFORMAT_DEPTH32_FLOAT,
        ...options,
    };
`

[Popov72]

Yes, my bad, everything is ok with no change!

[RaananW]

This is good to merge, right?

[Popov72]

Ok for me.