Makefile: specify RPATH using $ORIGIN #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when dynamically linking against libcaffe (right now, only done for tests), RPATH is specified relative to the caffe source root. This commit fixes RPATH using the special $ORIGIN variable to be relative to the executable itself, so that there is no dependence on the working directory.
shelhamer
added a commit
that referenced
this pull request
Jan 16, 2015
Makefile: specify RPATH using $ORIGIN
|
Sounds good -- is the future dynamic linking for the tools and pycaffe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when dynamically linking against libcaffe (right now, only done for tests), RPATH is specified relative to the caffe source root, which means the resulting executable has to be executed from the same directory.
This commit uses the special $ORIGIN variable of RPATH to specify a path relative to the executable itself, so that there is no dependence on the working directory. (This is broken out into a make variable,
DYNAMIC_LDFLAGS, that will be useful in a future PR.)