Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BNFTP protocol detection #1

Open
cen1 opened this issue Apr 22, 2017 · 3 comments
Open

Fix BNFTP protocol detection #1

cen1 opened this issue Apr 22, 2017 · 3 comments
Labels

Comments

@cen1
Copy link

cen1 commented Apr 22, 2017

No description provided.

@carlbennett carlbennett changed the title Add BNFTP protocol detection Fix BNFTP protocol detection Apr 22, 2017
@carlbennett
Copy link
Member

It is already semi-aware of BNFTP:

local f_type = ProtoField.uint8("bnetp.type","Header Type",base.HEX, {
[0x1] = "Game protocol request",
[0x2] = "FTP protocol request",
[0x3] = "Chat protocol request",
[0xF7] = "W3IGP",
[0xFF] = "BNCS",
})

It just needs to be fixed.

@carlbennett
Copy link
Member

More specifically, it correctly identified ver-IX86-5.mpq as FTP_PROTOCOL (BNFTP), however it did not identify icons-WAR3.bni as such.

@cen1
Copy link
Author

cen1 commented Apr 27, 2017

It is aware of bnftp yes but it does not have the protocol implementation, just detects the header. It needs to be implemented for bnftp v1 and v2. I'll give it a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants