Don't use by reference

Author: carlbennett

src/controllers/Credits.php

@@ -25,12 +25,12 @@ protected function getCredits(CreditsModel &$model) {
     $credits = new CreditsLib();
     $model->total_users = CreditsLib::getTotalUsers();
     $model->top_contributors_by_documents
-      = &$credits->getTopContributorsByDocuments();
+      = $credits->getTopContributorsByDocuments();
     $model->top_contributors_by_news_posts
-      = &$credits->getTopContributorsByNewsPosts();
+      = $credits->getTopContributorsByNewsPosts();
     $model->top_contributors_by_packets
-      = &$credits->getTopContributorsByPackets();
+      = $credits->getTopContributorsByPackets();
     $model->top_contributors_by_servers
-      = &$credits->getTopContributorsByServers();
+      = $credits->getTopContributorsByServers();
   }
 }

src/libraries/Credits.php

@@ -10,7 +10,7 @@
 
 class Credits {
 
-  public static function &getTotalUsers() {
+  public static function getTotalUsers() {
     if (!isset(Common::$database)) {
       Common::$database = DatabaseDriver::getDatabaseObject();
     }
@@ -23,7 +23,7 @@ public static function &getTotalUsers() {
     return (int) $obj->sum;
   }
 
-  public function &getTopContributorsByDocuments() {
+  public function getTopContributorsByDocuments() {
     if (!isset(Common::$database)) {
       Common::$database = DatabaseDriver::getDatabaseObject();
     }
@@ -55,7 +55,7 @@ public function &getTopContributorsByDocuments() {
     return $result;
   }
 
-  public function &getTopContributorsByNewsPosts() {
+  public function getTopContributorsByNewsPosts() {
     if (!isset(Common::$database)) {
       Common::$database = DatabaseDriver::getDatabaseObject();
     }
@@ -87,7 +87,7 @@ public function &getTopContributorsByNewsPosts() {
     return $result;
   }
 
-  public function &getTopContributorsByPackets() {
+  public function getTopContributorsByPackets() {
     if (!isset(Common::$database)) {
       Common::$database = DatabaseDriver::getDatabaseObject();
     }
@@ -119,7 +119,7 @@ public function &getTopContributorsByPackets() {
     return $result;
   }
 
-  public function &getTopContributorsByServers() {
+  public function getTopContributorsByServers() {
     if (!isset(Common::$database)) {
       Common::$database = DatabaseDriver::getDatabaseObject();
     }