Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Move to develop+master branch + tags for future releases #151

Open
gdevenyi opened this issue May 16, 2022 · 10 comments
Open

Proposal: Move to develop+master branch + tags for future releases #151

gdevenyi opened this issue May 16, 2022 · 10 comments

Comments

@gdevenyi
Copy link
Contributor

Currently, we have at least two "develop" branches on the go, which have been diverging from master and each other.

I'm doing updates and I'd like to work out a new release, but I'm not sure how I would achieve this right now.

I'd like to propose moving to a develop (PRs against develop, active dev goes there) + master (stable branch, merge develop periodically when "known good"), and tag releases on master.

Thoughts @vfonov? Others?

@gdevenyi
Copy link
Contributor Author

This would also enable a bit more continuous integration (and maybe even auto-builds on release...)

@vfonov
Copy link
Member

vfonov commented May 16, 2022

well, I am stuck with switching to ITK-5, too many breaking changes

@gdevenyi
Copy link
Contributor Author

Perhaps that would be "feature branch to be eventually merged into develop"?

Is there a todo/list of things I could potentially help with for the ITK5 porting?

@bcdarwin
Copy link
Contributor

bcdarwin commented May 16, 2022

What packages remain to be ported -- EZminc and ABC?

[edit: EZminc has already been ported to 5.0 but needs tweaking for 5.2]

@bcdarwin
Copy link
Contributor

I agree that the current branching model is leading to stale/unbuildable branches -- potentially could be fixed by having bots look for certain tags and automatically backporting but a simpler model is probably better.

@gdevenyi
Copy link
Contributor Author

Also worth asking, for the ITK software, can we upstream anything that isn't ours, since MINC is "first class" in ITK?

@bcdarwin
Copy link
Contributor

These days I already use upstream ANTs/Elastix/c3d (which have moved to ITK5) with no problems (except the usual disagreement between mnc2nii and ITK coordinate system conversion).

@vfonov
Copy link
Member

vfonov commented May 16, 2022

i had trouble with elastix , because the version in minc-toolkit contains my modifications to output minc .xfm files.
Also, I had to disable everything related to diffeomorphic demons.

@gdevenyi
Copy link
Contributor Author

These days I already use upstream ANTs/Elastix/c3d (which have moved to ITK5) with no problems (except the usual disagreement between mnc2nii and ITK coordinate system conversion).

We Can Rebuilld Him, We Have the Technology

InsightSoftwareConsortium/ITK#147

@gdevenyi
Copy link
Contributor Author

So, can we coordinate on a next step for development?

  1. What happens on master branch? Do we merge 1.9.18.2?
  2. Can merge 1.9.18-develop into 1.9.19-develop and continue work there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants