Merge branch 'release/V4.0.2.4'

Author: Gwenou

docs/30-BIAToolKit/10-ConfigureTheBIAToolKit.md

@@ -8,8 +8,13 @@ This document explains how to configure the BIA tool kit, to be ready to apply t
 ![BIAToolKitConfig](../Images/BIAToolKit/Config.PNG)
 
 ## Get the BIAToolKit
-Take the last version of the BIAToolKit from [release](https://github.com/BIATeam/BIAToolKit/releases) or from your company folder if you have one. 
+Take the last version of the "BIAToolKit.zip" from [last release](https://github.com/BIATeam/BIAToolKit/releases).
+Unzip it and launch the BIA.ToolKit.exe
+![BIAToolKitConfig](../Images/BIAToolKit/Launch.PNG)
 
+If you have the Windows defender smart screen warning click on "More Info" then click "Run anyway"":
+![BIAToolKitConfig](../Images/BIAToolKit/WindowsDefender.png)
+![BIAToolKitConfig](../Images/BIAToolKit/WindowsDefender2.jpg)
 ## Configure your BIA Template repository
 In the first tab, in the upper left corner, chose if you want to use a local folder to synchronize it.
 * It is not required so if you don't have clone the BIATemplate locally select the first radio button "Use the BIAtemplate GitHub repository" the local folder will be : C:\Users\YourLogin\AppData\Local\BIA.ToolKit\BIA.ToolKit\1.0.0\BIATemplate\Repo

docs/50-BestPractices/10-GitBranchingBestPractices.md

@@ -21,10 +21,14 @@ The strategy depend on the size of the project:
 - Standard usage : work on Develop Branch
 - For huge feature you can create a dedicated branch.
 
-## Project more the 2 developers:
+## Project with more the 2 developers:
 - Standard usage : Develop all your Features on dedicated Branch
 - For very small change you can work directly on Develop Branch
 
+## Project with support (including feature) on last delivery
+- The notion of "hot feature" is introduce to be able to deliver small feature (less than 1 month) before the delivery of the next version (every 6 month).
+![GitFlow](../Images/GitFlow.jpg)
+
 ## Initialize gitflow extension
 - Just install the gitflow extension for VS Code.
   ![GitFlowExtension](../Images/GitFlowVSExtension.png)

docs/60-Migration/33-4.0.0 TO 4.1.0.md

@@ -45,6 +45,15 @@ sidebar_position: 1
 ```json
 "eqeqeq": "off"
 ```
+3. Moving advanced filters to the right :
+   1. Move advanced filter html after table in index.component
+   2. Move from table-header to table-controller html :
+```ts
+        [showBtnFilter]="true"
+        [showFilter]="showAdvancedFilter"
+        [hasFilter]="hasAdvancedFilter"
+        (openFilter)="onOpenFilter()"
+```
 
 ### BACK
 1. 

docs/60-Migration/Scripts/V4.0.0_to_V4.1.0_Replacement.ps1

@@ -219,8 +219,7 @@ function RemoveWebApiRepositoryFunctionsThirdParameter ($contenuFichier, $MatchB
   }
 }
 
-
-
+ReplaceInProject -Source $SourceFrontEnd -OldRegexp "((templateUrl|styleUrls?):\s*\[*\s*['""])(\.\.\/)+(shared\/.+?)['""]" -NewRegexp '$1/src/app/$4' -Include *.ts
 
 # Set-Location $Source/DotNet
 dotnet restore --no-cache

docs/Images/BIAToolKit/Launch.PNG

@@ -111,8 +111,48 @@ Warning : major change
     - .header h1
 
    3. in the .ts the variable fxFlexValue can be remove (and in CRUD index html where the component in call = action 6.)
+9. In every index.component that use advanced filters and views and does not extends CrudIndexComponent, you'll need to adapt the mechanism as follow :
+   1.  Delete the advancedFilter property :
+   ```ts
+   advancedFilter: MyFeatureAdvancedFilter;
+   ```
+   2. Replace all references to this deleted advancedFilter by this.tableConfiguration.advancedFilter.
+   3. Change onFilter function as follow : 
+    ```ts
+    onFilter(advancedFilter: MyFeatureAdvancedFilter) {
+      this.tableConfiguration.advancedFilter = advancedFilter;
+      this.myFeatureListComponent.table.saveState();
+      this.hasFilter = this.checkHaveFilter();
+      this.onLoadLazy(this.lastLazyLoadEvent);
+    }
+    ```
+    4. Change the updateAdvancedFilterByView function as follow :
+    ```ts
+    private updateAdvancedFilterByView(viewPreference: string) {
+      if (viewPreference) {
+        const state = JSON.parse(viewPreference);
+        if (state) {
+          this.tableConfiguration.advancedFilter = state.advancedFilter;
+          this.hasFilter = this.checkHaveFilter();
+        }
+      } else {
+        this.tableConfiguration.advancedFilter = {};
+        this.hasFilter = this.checkHaveFilter();
+      }
+    }
+    ```
+    5. In function checkHaveFilter, if you use this.tableConfiguration.advancedFilter in the if equality values, replace it like that :
+    ```ts
+    if (this.tableConfiguration.advancedFilter && ...)
+    ```
+    becomes
+    ```ts
+    if (!!this.tableConfiguration.advancedFilter && ...)
+    ```
+    This is due to the any type not being falsy even when undefined.
+    6. in your personalized advanced filter component, make sure to reset the advanced filter form when the advancedFilter input changes in ngChanges even when undefined or the values of advanced filter won't be reset when you select a view that has no advanced filters.
 
-9. Search fxLayoutGap in replace by a class equivalent ex:
+10. Search fxLayoutGap in replace by a class equivalent ex:
     fxLayoutGap="32px" ... fxLayoutGap="24px" => class="gap-4"   (1.5rem)
     fxLayoutGap="20px" ... fxLayoutGap="16px" => class="gap-3"   (1rem)
     fxLayoutGap="15px" ... fxLayoutGap="8px" => class="gap-2"    (0.5rem)
@@ -121,7 +161,7 @@ Warning : major change
 
     ref : https://primefaces.org/primeflex/gap and https://nekocalc.com/fr/px-a-rem-convertisseur
 
-10. If you used badges with numbers inside, add this css class in **_app-custom-theme.scss**
+11. If you used badges with numbers inside, add this css class in **_app-custom-theme.scss**
 
     ```css
     .bia-badge-with-number > .p-badge {
@@ -136,7 +176,7 @@ Warning : major change
     <i class="bia-badge-with-number" pBadge"></i>
     ```
 
-11. In src\app\shared\bia-shared\features\view\views\view-list\view-list.component.html
+12. In src\app\shared\bia-shared\features\view\views\view-list\view-list.component.html
 
     Replace
     ```html