Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

array_slice hardcoded value enables fickleness and vile display #78

Open
bdolor opened this issue Feb 2, 2018 · 0 comments
Open

array_slice hardcoded value enables fickleness and vile display #78

bdolor opened this issue Feb 2, 2018 · 0 comments

Comments

@bdolor
Copy link
Contributor

bdolor commented Feb 2, 2018

Description

in Views/BookReviews.php the way that $q_and_a is set via array_slice and private instance variable $slice https://github.com/BCcampus/opentextbooks/blob/dev/inc/Views/BookReviews.php#L58 makes it vulnerable to changes made to the form questions.

Expected behaviour

Reviews shouldn't break when users make changes to the form questions

Actual behaviour

The array of questions and answers is off, due to an increase in the array length.

Steps to reproduce the problem

change a question in LimeSurvey, watch the reviews fall apart.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bdolor