Skip to content

Add rule exceptions for prettier #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Add rule exceptions for prettier #28

merged 1 commit into from
Aug 31, 2021

Conversation

adrigzr
Copy link
Contributor

@adrigzr adrigzr commented Aug 30, 2021

ignored all prettier rules as defined in
https://github.com/prettier/eslint-config-prettier#special-rules

BREAKING CHANGE: removed a lot of style rules

@adrigzr adrigzr requested a review from a team August 30, 2021 10:16
ignored all prettier rules as defined in
https://github.com/prettier/eslint-config-prettier#special-rules

BREAKING CHANGE: removed a lot of style rules
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #28 (d99e0a4) into master (7554f49) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master       #28    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            1        11    +10     
  Lines            8       199   +191     
  Branches         0        59    +59     
==========================================
+ Hits             8       199   +191     
Impacted Files Coverage Δ
...s/eslint-plugin-bbva/lib/rules/_utils/ast-utils.js 100.00% <100.00%> (ø)
...ages/eslint-plugin-bbva/lib/rules/duplicated-if.js 100.00% <100.00%> (ø)
...ages/eslint-plugin-bbva/lib/rules/infinite-loop.js 100.00% <100.00%> (ø)
...eslint-plugin-bbva/lib/rules/inline-conditional.js 100.00% <100.00%> (ø)
...nt-plugin-bbva/lib/rules/jquery-selector-length.js 100.00% <100.00%> (ø)
...eslint-plugin-bbva/lib/rules/no-args-assignment.js 100.00% <100.00%> (ø)
...in-bbva/lib/rules/no-throw-in-unchained-promise.js 100.00% <100.00%> (ø)
...in-bbva/lib/rules/no-transition-abort-in-routes.js 100.00% <100.00%> (ø)
...bva/lib/rules/prefer-rsvp-promise-reject-errors.js 100.00% <100.00%> (ø)
...t-plugin-bbva/lib/rules/prefer-throw-in-promise.js 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7554f49...d99e0a4. Read the comment docs.

@adrigzr adrigzr merged commit 73eb29e into master Aug 31, 2021
@adrigzr adrigzr deleted the feature-prettier branch August 31, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants