You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are currently using the Software class from ASDF, which contains just a name and a version number. This does not integrate so well with our MeasurementChain in my opinion. Here is how we use a MeasurementEquipment with the MeasurementChain:
current_AD_transform=msm.SignalTransformation(
name="AD current conversion",
func=current_AD_func,
type_transformation="AD",
error=msm.Error(Q_(0.01, "percent")),
)
voltage_AD_transform=msm.SignalTransformation(
name="AD voltage conversion",
func=voltage_AD_func,
type_transformation="AD",
error=msm.Error(Q_(0.01, "percent")),
)
BH_ELM=msm.MeasurementEquipment(
name="Beckhoff ELM3002-0000",
transformations=[current_AD_transform, voltage_AD_transform],
)
welding_current_chain.add_transformation_from_equipment(
equipment=BH_ELM, transformation_name="AD current conversion"
)
Now here is the corresponding workflow for a Software:
The difference is, that I have to create the link between Software and transformation using the meta field and it is only in one direction. The way the MeasurementEquipment works feels more natural to me. You have a piece of equipment and it can perform some transformations. So when you describe a MeasuremertChain you just add the equipment and specify which of its transformations to use (if it has multiple). The rest is figured out by the MeasurementChain.
In the software workflow, I add the transformation directly to the Chain and just "mention" which equipment I used for it.
Basically, you can break it down into the following. With the MeasuremertEquipment I say:
"I used Equipment X to perform Operation Y"
With the software approach we say:
"I performed operation Y using Equipment X"
Apart from maybe being a bit picky here, I guess it is best to stick to one workflow for all pieces of the measurement chain. So my suggestion is to create our own small dataclass and schema for software.
The text was updated successfully, but these errors were encountered:
We are currently using the
Software
class from ASDF, which contains just a name and a version number. This does not integrate so well with ourMeasurementChain
in my opinion. Here is how we use aMeasurementEquipment
with theMeasurementChain
:Now here is the corresponding workflow for a Software:
The difference is, that I have to create the link between Software and transformation using the meta field and it is only in one direction. The way the
MeasurementEquipment
works feels more natural to me. You have a piece of equipment and it can perform some transformations. So when you describe aMeasuremertChain
you just add the equipment and specify which of its transformations to use (if it has multiple). The rest is figured out by the MeasurementChain.In the software workflow, I add the transformation directly to the Chain and just "mention" which equipment I used for it.
Basically, you can break it down into the following. With the
MeasuremertEquipment
I say:"I used Equipment X to perform Operation Y"
With the software approach we say:
"I performed operation Y using Equipment X"
Apart from maybe being a bit picky here, I guess it is best to stick to one workflow for all pieces of the measurement chain. So my suggestion is to create our own small
dataclass
and schema for software.The text was updated successfully, but these errors were encountered: