Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SciPy-1.6 version breaks WXRotation #226

Closed
vhirtham opened this issue Jan 13, 2021 · 7 comments · Fixed by #300
Closed

SciPy-1.6 version breaks WXRotation #226

vhirtham opened this issue Jan 13, 2021 · 7 comments · Fixed by #300
Labels
bug Something isn't working

Comments

@vhirtham
Copy link
Collaborator

The new SciPy release is not compatible with our WXRotations object. Some interfaces changed and some functions seem to be removed or renamed.

@vhirtham vhirtham added the bug Something isn't working label Jan 13, 2021
@marscher
Copy link
Collaborator

I think this has already been addressed upstream, but is not yet released scipy/scipy@1d4e9df

cref: asdf-format/asdf#916

@marscher marscher changed the title New SciPy version breaks WXRotation SciPy-1.6 version breaks WXRotation Feb 10, 2021
@marscher
Copy link
Collaborator

Upstream issue (scipy) is fixed, now we have to way for a release :)

@vhirtham
Copy link
Collaborator Author

@marscher They released version 2.7.3 recently that includes the fix

@marscher
Copy link
Collaborator

asdf-format/asdf#916 (comment) and re-opened the issue

@CagtayFabry
Copy link
Member

we will do a patch release to unpin scipy in the requirements after their next release 🚀

@CagtayFabry
Copy link
Member

CagtayFabry commented Mar 15, 2021

it appears scipy has assigned the fix to their 1.7.0 milestone which could take some time to release

Should we ask to include this into 1.6.2 @marscher ? IIRC there are no breaking changes introduced with this fix right?

@marscher
Copy link
Collaborator

marscher commented Mar 15, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants