From 48d134acf75aa11f65b3adfd254988c6c0f0a65e Mon Sep 17 00:00:00 2001 From: "FAREAST\\jiacfan" Date: Fri, 30 Aug 2019 15:04:45 +0800 Subject: [PATCH] [Storage](Queue) Update storage service version to 2019-02-02 and return x-ms-client-request-id through clientRequestId for all APIs. --- sdk/storage/storage-queue/ChangeLog.md | 11 +- .../src/generated/lib/models/index.ts | 120 ++++++++++++++++-- .../src/generated/lib/models/mappers.ts | 96 ++++++++++++++ .../src/generated/lib/models/parameters.ts | 18 ++- .../src/generated/lib/storageClientContext.ts | 2 +- .../storage-queue/test/messageidurl.spec.ts | 2 + .../storage-queue/test/messagesurl.spec.ts | 4 + .../test/node/messageidurl.spec.ts | 2 + .../test/node/messagesurl.spec.ts | 3 + .../storage-queue/test/node/queueurl.spec.ts | 1 + .../storage-queue/test/node/sas.spec.ts | 1 + .../storage-queue/test/queueurl.spec.ts | 1 + .../storage-queue/test/serviceurl.spec.ts | 2 + 13 files changed, 241 insertions(+), 22 deletions(-) diff --git a/sdk/storage/storage-queue/ChangeLog.md b/sdk/storage/storage-queue/ChangeLog.md index 9d16f96b5f0a..eb5d8ff19e40 100644 --- a/sdk/storage/storage-queue/ChangeLog.md +++ b/sdk/storage/storage-queue/ChangeLog.md @@ -1,6 +1,11 @@ # Changelog -2019.7 Version 10.2.0 +## 2019.09 Version 10.3.0 + +* Updated Azure Storage Service API version to 2019-02-02. +* Responses for all APIs now return x-ms-client-request-id through `clientRequestId` that was passed in on the request from client-side. + +## 2019.07 Version 10.2.0 * Fixed a bug that `Aborter` cannot work during retry interval. * Fixed a bug that "err.code.toUpperCase is not a function" when retries in browser. @@ -11,7 +16,7 @@ * A new option `keepAliveOptions` added to parameter of `StorageURL.newPipeline()` which controls keep-alive configurations. Keep-alive is enabled by default. * Updated Azure Storage Service API version to [2018-11-09](https://docs.microsoft.com/en-us/rest/api/storageservices/version-2018-11-09). -2019.1 Version 10.1.0 +## 2019.01 Version 10.1.0 * [Breaking] Updated convenience layer methods enum type parameters into typescript union types, this will help to reduce bundle footprint. * [Breaking] `SASQueryParameters` is not going to be exported in browser bundle, and will be exported in Node.js runtime. @@ -22,6 +27,6 @@ * Fixed an issue that enqueue/dequeue/peek fail to work with some utf8 characters. * Exported HttpRequestBody type for who wants to implement a customized HTTP client. -2018.12 Version 10.0.0-preview +## 2018.12 Version 10.0.0-preview * Initial Release. API version 2018-03-28 supported. Please see the README for information on the new design. diff --git a/sdk/storage/storage-queue/src/generated/lib/models/index.ts b/sdk/storage/storage-queue/src/generated/lib/models/index.ts index 8fd9609fe1b6..5fc11490a778 100644 --- a/sdk/storage/storage-queue/src/generated/lib/models/index.ts +++ b/sdk/storage/storage-queue/src/generated/lib/models/index.ts @@ -524,11 +524,11 @@ export interface ServiceListQueuesSegmentOptionalParams extends msRest.RequestOp */ maxresults?: number; /** - * @member {ListQueuesIncludeType} [include] Include this parameter to + * @member {ListQueuesIncludeType[]} [include] Include this parameter to * specify that the queues's metadata be returned as part of the response - * body. Possible values include: 'metadata' + * body. */ - include?: ListQueuesIncludeType; + include?: ListQueuesIncludeType[]; /** * @member {number} [timeoutParameter] The The timeout parameter is expressed * in seconds. For more information, see { assert.ok(eResult.messageId); assert.ok(eResult.popReceipt); assert.ok(eResult.requestId); + assert.ok(eResult.clientRequestId); assert.ok(eResult.timeNextVisible); assert.ok(eResult.version); @@ -48,6 +49,7 @@ describe("MessageIdURL", () => { assert.ok(uResult.timeNextVisible); assert.ok(uResult.date); assert.ok(uResult.requestId); + assert.ok(eResult.clientRequestId); assert.ok(uResult.popReceipt); let pResult = await messagesURL.peek(Aborter.none); diff --git a/sdk/storage/storage-queue/test/messagesurl.spec.ts b/sdk/storage/storage-queue/test/messagesurl.spec.ts index 46682a0c0c64..106ce2eb7fa4 100644 --- a/sdk/storage/storage-queue/test/messagesurl.spec.ts +++ b/sdk/storage/storage-queue/test/messagesurl.spec.ts @@ -37,6 +37,7 @@ describe("MessagesURL", () => { assert.ok(eResult.messageId); assert.ok(eResult.popReceipt); assert.ok(eResult.requestId); + assert.ok(eResult.clientRequestId); assert.ok(eResult.timeNextVisible); assert.ok(eResult.version); @@ -45,6 +46,7 @@ describe("MessagesURL", () => { let pResult = await messagesURL.peek(Aborter.none); assert.ok(pResult.date); assert.ok(pResult.requestId); + assert.ok(eResult.clientRequestId); assert.ok(pResult.version); assert.deepStrictEqual(pResult.peekedMessageItems.length, 1); assert.deepStrictEqual(pResult.peekedMessageItems[0].messageText, messageContent); @@ -53,6 +55,7 @@ describe("MessagesURL", () => { let dqResult = await messagesURL.dequeue(Aborter.none); assert.ok(dqResult.date); assert.ok(dqResult.requestId); + assert.ok(eResult.clientRequestId); assert.ok(dqResult.version); assert.deepStrictEqual(dqResult.dequeuedMessageItems.length, 1); assert.ok(dqResult.dequeuedMessageItems[0].popReceipt); @@ -62,6 +65,7 @@ describe("MessagesURL", () => { let cResult = await messagesURL.clear(Aborter.none); assert.ok(cResult.date); assert.ok(cResult.requestId); + assert.ok(eResult.clientRequestId); assert.ok(cResult.version); // check all messages are cleared diff --git a/sdk/storage/storage-queue/test/node/messageidurl.spec.ts b/sdk/storage/storage-queue/test/node/messageidurl.spec.ts index dfdc2d89f8cd..aa4dacab7962 100644 --- a/sdk/storage/storage-queue/test/node/messageidurl.spec.ts +++ b/sdk/storage/storage-queue/test/node/messageidurl.spec.ts @@ -36,6 +36,7 @@ describe("MessageIdURL Node", () => { assert.ok(eResult.messageId); assert.ok(eResult.popReceipt); assert.ok(eResult.requestId); + assert.ok(eResult.clientRequestId); assert.ok(eResult.timeNextVisible); assert.ok(eResult.version); @@ -51,6 +52,7 @@ describe("MessageIdURL Node", () => { assert.ok(uResult.timeNextVisible); assert.ok(uResult.date); assert.ok(uResult.requestId); + assert.ok(eResult.clientRequestId); assert.ok(uResult.popReceipt); let pResult = await messagesURL.peek(Aborter.none); diff --git a/sdk/storage/storage-queue/test/node/messagesurl.spec.ts b/sdk/storage/storage-queue/test/node/messagesurl.spec.ts index 3114704e30d3..aa48569721c2 100644 --- a/sdk/storage/storage-queue/test/node/messagesurl.spec.ts +++ b/sdk/storage/storage-queue/test/node/messagesurl.spec.ts @@ -44,12 +44,14 @@ describe("MessagesURL Node", () => { assert.ok(eResult.messageId); assert.ok(eResult.popReceipt); assert.ok(eResult.requestId); + assert.ok(eResult.clientRequestId); assert.ok(eResult.timeNextVisible); assert.ok(eResult.version); let pResult = await messagesURL.peek(Aborter.none, { numberOfMessages: 2 }); assert.ok(pResult.date); assert.ok(pResult.requestId); + assert.ok(eResult.clientRequestId); assert.ok(pResult.version); assert.deepStrictEqual(pResult.peekedMessageItems.length, 1); assert.deepStrictEqual(pResult.peekedMessageItems[0].messageText, messageContent); @@ -64,6 +66,7 @@ describe("MessagesURL Node", () => { }); assert.ok(dResult.date); assert.ok(dResult.requestId); + assert.ok(eResult.clientRequestId); assert.ok(dResult.version); assert.deepStrictEqual(dResult.dequeuedMessageItems.length, 1); assert.deepStrictEqual(dResult.dequeuedMessageItems[0].messageText, messageContent); diff --git a/sdk/storage/storage-queue/test/node/queueurl.spec.ts b/sdk/storage/storage-queue/test/node/queueurl.spec.ts index edca987912af..4119a31a1db5 100644 --- a/sdk/storage/storage-queue/test/node/queueurl.spec.ts +++ b/sdk/storage/storage-queue/test/node/queueurl.spec.ts @@ -27,6 +27,7 @@ describe("QueueURL Node", () => { it("getAccessPolicy", async () => { const result = await queueURL.getAccessPolicy(Aborter.none); assert.ok(result.requestId); + assert.ok(result.clientRequestId); assert.ok(result.version); assert.ok(result.date); }); diff --git a/sdk/storage/storage-queue/test/node/sas.spec.ts b/sdk/storage/storage-queue/test/node/sas.spec.ts index 09e3c93234ed..2bd201a6a0f8 100644 --- a/sdk/storage/storage-queue/test/node/sas.spec.ts +++ b/sdk/storage/storage-queue/test/node/sas.spec.ts @@ -334,6 +334,7 @@ describe("Shared Access Signature (SAS) generation Node.js only", () => { dResult.dequeuedMessageItems[0].popReceipt ); assert.ok(deleteResult.requestId); + assert.ok(deleteResult.clientRequestId); //const cResult = await messagesURLwithSAS.clear(Aborter.none); //This request is not authorized to perform this operation. As testing, this is service's current behavior. }); diff --git a/sdk/storage/storage-queue/test/queueurl.spec.ts b/sdk/storage/storage-queue/test/queueurl.spec.ts index 81007ff6f7f7..a77102a81fcf 100644 --- a/sdk/storage/storage-queue/test/queueurl.spec.ts +++ b/sdk/storage/storage-queue/test/queueurl.spec.ts @@ -42,6 +42,7 @@ describe("QueueURL", () => { const result = await queueURL.getProperties(Aborter.none); assert.ok(result.approximateMessagesCount! >= 0); assert.ok(result.requestId); + assert.ok(result.clientRequestId); assert.ok(result.version); assert.ok(result.date); }); diff --git a/sdk/storage/storage-queue/test/serviceurl.spec.ts b/sdk/storage/storage-queue/test/serviceurl.spec.ts index 1d72a089f723..c36e4e695b38 100644 --- a/sdk/storage/storage-queue/test/serviceurl.spec.ts +++ b/sdk/storage/storage-queue/test/serviceurl.spec.ts @@ -24,6 +24,7 @@ describe("ServiceURL", () => { const result = await serviceURL.listQueuesSegment(Aborter.none); assert.ok(typeof result.requestId); assert.ok(result.requestId!.length > 0); + assert.ok(result.clientRequestId); assert.ok(typeof result.version); assert.ok(result.version!.length > 0); @@ -79,6 +80,7 @@ describe("ServiceURL", () => { assert.ok(typeof result.requestId); assert.ok(result.requestId!.length > 0); + assert.ok(result.clientRequestId); assert.ok(typeof result.version); assert.ok(result.version!.length > 0);