From b7bcbe358a7d4e4404d48844f9b3e582d02595cd Mon Sep 17 00:00:00 2001 From: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com> Date: Thu, 30 Sep 2021 14:11:01 -0700 Subject: [PATCH] [Storage] Try GMavenPlus to unblock Java 17 adoption. (#24471) * lets try. * fix java8 * fix java8 again:/ * track 1 --- eng/versioning/external_dependencies.txt | 1 + sdk/storage/azure-storage-blob-batch/pom.xml | 130 ++++++++++++----- .../azure-storage-blob-changefeed/pom.xml | 130 ++++++++++++----- .../azure-storage-blob-cryptography/pom.xml | 130 ++++++++++++----- sdk/storage/azure-storage-blob-nio/pom.xml | 130 ++++++++++++----- sdk/storage/azure-storage-blob/pom.xml | 130 ++++++++++++----- sdk/storage/azure-storage-common/pom.xml | 136 +++++++++++++----- .../common/test/shared/ThreadDumper.java | 2 +- .../azure-storage-file-datalake/pom.xml | 130 ++++++++++++----- sdk/storage/azure-storage-file-share/pom.xml | 132 ++++++++++++----- .../azure-storage-internal-avro/pom.xml | 130 ++++++++++++----- sdk/storage/azure-storage-queue/pom.xml | 132 ++++++++++++----- .../microsoft-azure-storage-blob/pom.xml | 118 +++++++++++---- 13 files changed, 1059 insertions(+), 372 deletions(-) diff --git a/eng/versioning/external_dependencies.txt b/eng/versioning/external_dependencies.txt index ae20b646c28fe..76eb25a4cae0d 100644 --- a/eng/versioning/external_dependencies.txt +++ b/eng/versioning/external_dependencies.txt @@ -81,6 +81,7 @@ org.apache.qpid:proton-j;0.33.8 org.apache.qpid:qpid-jms-client;0.53.0 org.apache.tinkerpop:gremlin-driver;3.2.4 org.asynchttpclient:async-http-client;2.12.1 +org.codehaus.gmavenplus:gmavenplus-plugin;1.13.0 org.codehaus.groovy:groovy-eclipse-batch;2.5.8-01 org.codehaus.groovy:groovy-eclipse-compiler;3.4.0-01 org.conscrypt:conscrypt-openjdk-uber;2.2.1 diff --git a/sdk/storage/azure-storage-blob-batch/pom.xml b/sdk/storage/azure-storage-blob-batch/pom.xml index df3a2da3af2f8..22ba1d7091d60 100644 --- a/sdk/storage/azure-storage-blob-batch/pom.xml +++ b/sdk/storage/azure-storage-blob-batch/pom.xml @@ -170,40 +170,102 @@ ${basedir}/src/test/resources - - - - org.apache.maven.plugins - maven-compiler-plugin - 3.8.1 - - - default-testCompile - process-test-sources - - testCompile - + + + + java8 + + [1.8,9) + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + groovy-eclipse-compiler + + -warn:-unused + + + + + + + org.codehaus.groovy + groovy-eclipse-compiler + 3.4.0-01 + + + org.codehaus.groovy + groovy-eclipse-batch + 2.5.8-01 + + + + + + + + java9plus + + [9,) + + + + + org.codehaus.gmavenplus + gmavenplus-plugin + 1.13.0 + + + + addTestSources + generateTestStubs + compileTests + removeTestStubs + + + - groovy-eclipse-compiler - - -warn:-unused - + + + ${project.basedir}/src/test + + **/*.groovy + + + - - - - - org.codehaus.groovy - groovy-eclipse-compiler - 3.4.0-01 - - - org.codehaus.groovy - groovy-eclipse-batch - 2.5.8-01 - - - - - + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + false + + + + + + + + diff --git a/sdk/storage/azure-storage-blob-changefeed/pom.xml b/sdk/storage/azure-storage-blob-changefeed/pom.xml index 36600950be84a..561a7d341543e 100644 --- a/sdk/storage/azure-storage-blob-changefeed/pom.xml +++ b/sdk/storage/azure-storage-blob-changefeed/pom.xml @@ -182,40 +182,102 @@ ${basedir}/src/test/resources - - - - org.apache.maven.plugins - maven-compiler-plugin - 3.8.1 - - - default-testCompile - process-test-sources - - testCompile - + + + + java8 + + [1.8,9) + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + groovy-eclipse-compiler + + -warn:-unused + + + + + + + org.codehaus.groovy + groovy-eclipse-compiler + 3.4.0-01 + + + org.codehaus.groovy + groovy-eclipse-batch + 2.5.8-01 + + + + + + + + java9plus + + [9,) + + + + + org.codehaus.gmavenplus + gmavenplus-plugin + 1.13.0 + + + + addTestSources + generateTestStubs + compileTests + removeTestStubs + + + - groovy-eclipse-compiler - - -warn:-unused - + + + ${project.basedir}/src/test + + **/*.groovy + + + - - - - - org.codehaus.groovy - groovy-eclipse-compiler - 3.4.0-01 - - - org.codehaus.groovy - groovy-eclipse-batch - 2.5.8-01 - - - - - + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + false + + + + + + + + diff --git a/sdk/storage/azure-storage-blob-cryptography/pom.xml b/sdk/storage/azure-storage-blob-cryptography/pom.xml index 9e07e0ee94cef..c4be60042be50 100644 --- a/sdk/storage/azure-storage-blob-cryptography/pom.xml +++ b/sdk/storage/azure-storage-blob-cryptography/pom.xml @@ -162,41 +162,101 @@ test - - - - - org.apache.maven.plugins - maven-compiler-plugin - 3.8.1 - - - default-testCompile - process-test-sources - - testCompile - + + + java8 + + [1.8,9) + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + groovy-eclipse-compiler + + -warn:-unused + + + + + + + org.codehaus.groovy + groovy-eclipse-compiler + 3.4.0-01 + + + org.codehaus.groovy + groovy-eclipse-batch + 2.5.8-01 + + + + + + + + java9plus + + [9,) + + + + + org.codehaus.gmavenplus + gmavenplus-plugin + 1.13.0 + + + + addTestSources + generateTestStubs + compileTests + removeTestStubs + + + - groovy-eclipse-compiler - - -warn:-unused - + + + ${project.basedir}/src/test + + **/*.groovy + + + - - - - - org.codehaus.groovy - groovy-eclipse-compiler - 3.4.0-01 - - - org.codehaus.groovy - groovy-eclipse-batch - 2.5.8-01 - - - - - + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + false + + + + + + + + diff --git a/sdk/storage/azure-storage-blob-nio/pom.xml b/sdk/storage/azure-storage-blob-nio/pom.xml index 596572948375a..fb7c8d746af49 100644 --- a/sdk/storage/azure-storage-blob-nio/pom.xml +++ b/sdk/storage/azure-storage-blob-nio/pom.xml @@ -147,40 +147,102 @@ ${basedir}/src/test/resources - - - - org.apache.maven.plugins - maven-compiler-plugin - 3.8.1 - - - default-testCompile - process-test-sources - - testCompile - + + + + java8 + + [1.8,9) + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + groovy-eclipse-compiler + + -warn:-unused + + + + + + + org.codehaus.groovy + groovy-eclipse-compiler + 3.4.0-01 + + + org.codehaus.groovy + groovy-eclipse-batch + 2.5.8-01 + + + + + + + + java9plus + + [9,) + + + + + org.codehaus.gmavenplus + gmavenplus-plugin + 1.13.0 + + + + addTestSources + generateTestStubs + compileTests + removeTestStubs + + + - groovy-eclipse-compiler - - -warn:-unused - + + + ${project.basedir}/src/test + + **/*.groovy + + + - - - - - org.codehaus.groovy - groovy-eclipse-compiler - 3.4.0-01 - - - org.codehaus.groovy - groovy-eclipse-batch - 2.5.8-01 - - - - - + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + false + + + + + + + + diff --git a/sdk/storage/azure-storage-blob/pom.xml b/sdk/storage/azure-storage-blob/pom.xml index a0c76a529a340..38263733e4989 100644 --- a/sdk/storage/azure-storage-blob/pom.xml +++ b/sdk/storage/azure-storage-blob/pom.xml @@ -180,41 +180,6 @@ ${basedir}/src/test/resources - - - - org.apache.maven.plugins - maven-compiler-plugin - 3.8.1 - - - default-testCompile - process-test-sources - - testCompile - - - groovy-eclipse-compiler - - -warn:-unused - - - - - - - org.codehaus.groovy - groovy-eclipse-compiler - 3.4.0-01 - - - org.codehaus.groovy - groovy-eclipse-batch - 2.5.8-01 - - - - @@ -259,5 +224,100 @@ + + java8 + + [1.8,9) + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + groovy-eclipse-compiler + + -warn:-unused + + + + + + + org.codehaus.groovy + groovy-eclipse-compiler + 3.4.0-01 + + + org.codehaus.groovy + groovy-eclipse-batch + 2.5.8-01 + + + + + + + + java9plus + + [9,) + + + + + org.codehaus.gmavenplus + gmavenplus-plugin + 1.13.0 + + + + addTestSources + generateTestStubs + compileTests + removeTestStubs + + + + + + + ${project.basedir}/src/test + + **/*.groovy + + + + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + false + + + + + + + diff --git a/sdk/storage/azure-storage-common/pom.xml b/sdk/storage/azure-storage-common/pom.xml index 78902aa632601..8fc4f2d2750fd 100644 --- a/sdk/storage/azure-storage-common/pom.xml +++ b/sdk/storage/azure-storage-common/pom.xml @@ -173,39 +173,109 @@ - - - org.apache.maven.plugins - maven-compiler-plugin - 3.8.1 - - - default-testCompile - process-test-sources - - testCompile - - - groovy-eclipse-compiler - - -warn:-unused - - - - - - - org.codehaus.groovy - groovy-eclipse-compiler - 3.4.0-01 - - - org.codehaus.groovy - groovy-eclipse-batch - 2.5.8-01 - - - + + + java8 + + [1.8,9) + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + groovy-eclipse-compiler + + -warn:-unused + + + + + + + org.codehaus.groovy + groovy-eclipse-compiler + 3.4.0-01 + + + org.codehaus.groovy + groovy-eclipse-batch + 2.5.8-01 + + + + + + + + java9plus + + [9,) + + + + + org.codehaus.gmavenplus + gmavenplus-plugin + 1.13.0 + + + + addTestSources + generateTestStubs + compileTests + removeTestStubs + + + + + + + ${project.basedir}/src/test + + **/*.groovy + + + + ${project.basedir}/src/test-shared + + **/*.groovy + + + + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + false + + + + + + + + diff --git a/sdk/storage/azure-storage-common/src/test-shared/java/com/azure/storage/common/test/shared/ThreadDumper.java b/sdk/storage/azure-storage-common/src/test-shared/java/com/azure/storage/common/test/shared/ThreadDumper.java index bc1f318e6c61c..9d320e70a9564 100644 --- a/sdk/storage/azure-storage-common/src/test-shared/java/com/azure/storage/common/test/shared/ThreadDumper.java +++ b/sdk/storage/azure-storage-common/src/test-shared/java/com/azure/storage/common/test/shared/ThreadDumper.java @@ -13,7 +13,7 @@ public class ThreadDumper { - private static final ClientLogger LOGGER = new ClientLogger(StorageSpec.class); + private static final ClientLogger LOGGER = new ClientLogger(ThreadDumper.class); private static volatile ScheduledExecutorService executorService; // Assume that after 30 minutes test job hangs. diff --git a/sdk/storage/azure-storage-file-datalake/pom.xml b/sdk/storage/azure-storage-file-datalake/pom.xml index cedb1456a7ab7..a38991c10a941 100644 --- a/sdk/storage/azure-storage-file-datalake/pom.xml +++ b/sdk/storage/azure-storage-file-datalake/pom.xml @@ -184,41 +184,6 @@ ${basedir}/src/test/resources - - - - org.apache.maven.plugins - maven-compiler-plugin - 3.8.1 - - - default-testCompile - process-test-sources - - testCompile - - - groovy-eclipse-compiler - - -warn:-unused - - - - - - - org.codehaus.groovy - groovy-eclipse-compiler - 3.4.0-01 - - - org.codehaus.groovy - groovy-eclipse-batch - 2.5.8-01 - - - - @@ -261,5 +226,100 @@ + + java8 + + [1.8,9) + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + groovy-eclipse-compiler + + -warn:-unused + + + + + + + org.codehaus.groovy + groovy-eclipse-compiler + 3.4.0-01 + + + org.codehaus.groovy + groovy-eclipse-batch + 2.5.8-01 + + + + + + + + java9plus + + [9,) + + + + + org.codehaus.gmavenplus + gmavenplus-plugin + 1.13.0 + + + + addTestSources + generateTestStubs + compileTests + removeTestStubs + + + + + + + ${project.basedir}/src/test + + **/*.groovy + + + + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + false + + + + + + + diff --git a/sdk/storage/azure-storage-file-share/pom.xml b/sdk/storage/azure-storage-file-share/pom.xml index fbd233caa36ef..bcc198ed9dc31 100644 --- a/sdk/storage/azure-storage-file-share/pom.xml +++ b/sdk/storage/azure-storage-file-share/pom.xml @@ -145,43 +145,6 @@ - - - - org.apache.maven.plugins - maven-compiler-plugin - 3.8.1 - - - default-testCompile - process-test-sources - - testCompile - - - groovy-eclipse-compiler - - -warn:-unused - - - - - - - org.codehaus.groovy - groovy-eclipse-compiler - 3.4.0-01 - - - org.codehaus.groovy - groovy-eclipse-batch - 2.5.8-01 - - - - - - inject-sas-service-version @@ -222,5 +185,100 @@ + + java8 + + [1.8,9) + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + groovy-eclipse-compiler + + -warn:-unused + + + + + + + org.codehaus.groovy + groovy-eclipse-compiler + 3.4.0-01 + + + org.codehaus.groovy + groovy-eclipse-batch + 2.5.8-01 + + + + + + + + java9plus + + [9,) + + + + + org.codehaus.gmavenplus + gmavenplus-plugin + 1.13.0 + + + + addTestSources + generateTestStubs + compileTests + removeTestStubs + + + + + + + ${project.basedir}/src/test + + **/*.groovy + + + + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + false + + + + + + + diff --git a/sdk/storage/azure-storage-internal-avro/pom.xml b/sdk/storage/azure-storage-internal-avro/pom.xml index 1177115f925ee..72cf9a0f271b0 100644 --- a/sdk/storage/azure-storage-internal-avro/pom.xml +++ b/sdk/storage/azure-storage-internal-avro/pom.xml @@ -171,39 +171,103 @@ - - - org.apache.maven.plugins - maven-compiler-plugin - 3.8.1 - - - default-testCompile - process-test-sources - - testCompile - - - groovy-eclipse-compiler - - -warn:-unused - - - - - - - org.codehaus.groovy - groovy-eclipse-compiler - 3.4.0-01 - - - org.codehaus.groovy - groovy-eclipse-batch - 2.5.8-01 - - - + + + java8 + + [1.8,9) + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + groovy-eclipse-compiler + + -warn:-unused + + + + + + + org.codehaus.groovy + groovy-eclipse-compiler + 3.4.0-01 + + + org.codehaus.groovy + groovy-eclipse-batch + 2.5.8-01 + + + + + + + + java9plus + + [9,) + + + + + org.codehaus.gmavenplus + gmavenplus-plugin + 1.13.0 + + + + addTestSources + generateTestStubs + compileTests + removeTestStubs + + + + + + + ${project.basedir}/src/test + + **/*.groovy + + + + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + false + + + + + + + + diff --git a/sdk/storage/azure-storage-queue/pom.xml b/sdk/storage/azure-storage-queue/pom.xml index 27e6c0955abc2..5a81a4fcce827 100644 --- a/sdk/storage/azure-storage-queue/pom.xml +++ b/sdk/storage/azure-storage-queue/pom.xml @@ -126,43 +126,6 @@ - - - - org.apache.maven.plugins - maven-compiler-plugin - 3.8.1 - - - default-testCompile - process-test-sources - - testCompile - - - groovy-eclipse-compiler - - -warn:-unused - - - - - - - org.codehaus.groovy - groovy-eclipse-compiler - 3.4.0-01 - - - org.codehaus.groovy - groovy-eclipse-batch - 2.5.8-01 - - - - - - inject-sas-service-version @@ -203,5 +166,100 @@ + + java8 + + [1.8,9) + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + groovy-eclipse-compiler + + -warn:-unused + + + + + + + org.codehaus.groovy + groovy-eclipse-compiler + 3.4.0-01 + + + org.codehaus.groovy + groovy-eclipse-batch + 2.5.8-01 + + + + + + + + java9plus + + [9,) + + + + + org.codehaus.gmavenplus + gmavenplus-plugin + 1.13.0 + + + + addTestSources + generateTestStubs + compileTests + removeTestStubs + + + + + + + ${project.basedir}/src/test + + **/*.groovy + + + + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + false + + + + + + + diff --git a/sdk/storage/microsoft-azure-storage-blob/pom.xml b/sdk/storage/microsoft-azure-storage-blob/pom.xml index 922faf324d924..033f983a9281f 100644 --- a/sdk/storage/microsoft-azure-storage-blob/pom.xml +++ b/sdk/storage/microsoft-azure-storage-blob/pom.xml @@ -99,32 +99,102 @@ src/main/java src/test/java - + + + + java8 + + [1.8,9) + + - - org.apache.maven.plugins - maven-compiler-plugin - 3.8.1 + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + - groovy-eclipse-compiler - -Xlint:unchecked - 1.8 - 1.8 - true + groovy-eclipse-compiler + + -warn:-unused + - - - org.codehaus.groovy - groovy-eclipse-compiler - 3.4.0-01 - - - org.codehaus.groovy - groovy-eclipse-batch - 2.5.8-01 - - - + + + + + org.codehaus.groovy + groovy-eclipse-compiler + 3.4.0-01 + + + org.codehaus.groovy + groovy-eclipse-batch + 2.5.8-01 + + + - + + + + java9plus + + [9,) + + + + + org.codehaus.gmavenplus + gmavenplus-plugin + 1.13.0 + + + + addTestSources + generateTestStubs + compileTests + removeTestStubs + + + + + + + ${project.basedir}/src/test + + **/*.groovy + + + + + + + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.1 + + + default-testCompile + process-test-sources + + testCompile + + + false + + + + + + + +