Skip to content

Commit c8c2d3e

Browse files
committed
Taking in CR comments which included cpelling correction and message correction
1 parent e7caa84 commit c8c2d3e

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/PSRecoveryServicesClient/PSRecoveryServicesVaultExtendedInfoClient.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public async Task<UploadCertificateResponse> UpdateVaultCertificate(CertificateA
6868
/// <param name="vault">vault object</param>
6969
/// <param name="site">site object </param>
7070
/// <returns>credential object</returns>
71-
public ASRVaultCreds GetVaultCrentials(X509Certificate2 managementCert, ASRVault vault, Site site)
71+
public ASRVaultCreds GenerateVaultCredential(X509Certificate2 managementCert, ASRVault vault, Site site)
7272
{
7373
Utilities.UpdateVaultSettings(new ASRVaultCreds()
7474
{
@@ -92,7 +92,7 @@ public ASRVaultCreds GetVaultCrentials(X509Certificate2 managementCert, ASRVault
9292
acsDetails = uploadCertificate.Result;
9393
channelIntegrityKey = getChannelIntegrityKey.Result;
9494

95-
ASRVaultCreds asrVaultCreds = this.GenerateCredential(
95+
ASRVaultCreds asrVaultCreds = this.GenerateCredentialObject(
9696
managementCert,
9797
acsDetails,
9898
channelIntegrityKey,
@@ -149,15 +149,15 @@ private async Task<string> GetChannelIntegrityKey()
149149

150150
if (extendedInfo == null)
151151
{
152-
extendedInfo = this.CreateVaultExtendedInformatino();
152+
extendedInfo = this.CreateVaultExtendedInformation();
153153
}
154154
else
155155
{
156156
if (!extendedInfo.Algorithm.Equals(CryptoAlgorithm.None.ToString(), StringComparison.InvariantCultureIgnoreCase))
157157
{
158158
// In case this condition is true that means the credential was first generated in portal
159159
// and hence can not be fetched here.
160-
throw new CloudException(Resources.VaultCredentialGenerationUnSopported);
160+
throw new CloudException(Resources.VaultCredentialGenerationUnSupported);
161161
}
162162
}
163163

@@ -168,7 +168,7 @@ private async Task<string> GetChannelIntegrityKey()
168168
/// Method to create the extended info for the vault.
169169
/// </summary>
170170
/// <returns>returns the object as task</returns>
171-
private ResourceExtendedInfo CreateVaultExtendedInformatino()
171+
private ResourceExtendedInfo CreateVaultExtendedInformation()
172172
{
173173
ResourceExtendedInfo extendedInfo = new ResourceExtendedInfo();
174174
extendedInfo.GenerateSecurityInfo();
@@ -187,7 +187,7 @@ private ResourceExtendedInfo CreateVaultExtendedInformatino()
187187
/// <param name="vault">vault object</param>
188188
/// <param name="site">site object</param>
189189
/// <returns>vault credential object</returns>
190-
private ASRVaultCreds GenerateCredential(X509Certificate2 managementCert, UploadCertificateResponse acsDetails, string channelIntegrityKey, ASRVault vault, Site site)
190+
private ASRVaultCreds GenerateCredentialObject(X509Certificate2 managementCert, UploadCertificateResponse acsDetails, string channelIntegrityKey, ASRVault vault, Site site)
191191
{
192192
string serializedCertifivate = Convert.ToBase64String(managementCert.Export(X509ContentType.Pfx));
193193

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Properties/Resources.Designer.cs

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Properties/Resources.resx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ ClientRequestId: {3}</value>
200200
<data name="ProtectionEntityAlreadyEnabled" xml:space="preserve">
201201
<value>Protection entity {0} is already enabled</value>
202202
</data>
203-
<data name="VaultCredentialGenerationUnSopported" xml:space="preserve">
204-
<value>Cannot generate vault credentials from powershell for this vault. Download the file from portal.</value>
203+
<data name="VaultCredentialGenerationUnSupported" xml:space="preserve">
204+
<value>Cannot generate vault credentials for this vault. Download it from the Azure Portal.</value>
205205
</data>
206206
</root>

src/ServiceManagement/RecoveryServices/Commands.RecoveryServices/Service/GetAzureSiteRecoveryVaultCredential.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ private void GetByObject()
149149
}
150150

151151
// Generate file.
152-
ASRVaultCreds vaultCreds = RecoveryServicesClient.GetVaultCrentials(
152+
ASRVaultCreds vaultCreds = RecoveryServicesClient.GenerateVaultCredential(
153153
cert,
154154
this.Vault,
155155
this.Site);

0 commit comments

Comments
 (0)