Skip to content

Commit

Permalink
No default values for the patch scenario with extension (#122)
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathan-innis authored May 4, 2022
1 parent f61151c commit 13c2533
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
12 changes: 7 additions & 5 deletions src/k8s-extension/azext_k8s_extension/custom.py
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,9 @@ def update_k8s_extension(
cluster_name,
name,
cluster_type,
auto_upgrade_minor_version="",
release_train="",
version="",
auto_upgrade_minor_version=None,
release_train=None,
version=None,
configuration_settings=None,
configuration_protected_settings=None,
configuration_settings_file=None,
Expand Down Expand Up @@ -261,13 +261,14 @@ def update_k8s_extension(
)
extension_type_lower = extension.extension_type.lower()

config_settings = {}
config_protected_settings = {}
config_settings = None
config_protected_settings = None
# Get Configuration Settings from file
if configuration_settings_file is not None:
config_settings = read_config_settings_file(configuration_settings_file)

if configuration_settings is not None:
config_settings = {}
for dicts in configuration_settings:
for key, value in dicts.items():
config_settings[key] = value
Expand All @@ -279,6 +280,7 @@ def update_k8s_extension(
)

if configuration_protected_settings is not None:
config_protected_settings = {}
for dicts in configuration_protected_settings:
for key, value in dicts.items():
config_protected_settings[key] = value
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1714,8 +1714,8 @@ class PatchExtension(msrest.serialization.Model):
def __init__(
self,
*,
auto_upgrade_minor_version: Optional[bool] = True,
release_train: Optional[str] = "Stable",
auto_upgrade_minor_version: Optional[bool] = None,
release_train: Optional[str] = None,
version: Optional[str] = None,
configuration_settings: Optional[Dict[str, str]] = None,
configuration_protected_settings: Optional[Dict[str, str]] = None,
Expand Down

0 comments on commit 13c2533

Please sign in to comment.