Fix net8.0 crypto floor: use patched System.Security.Cryptography.Xml 8.0.4 (not 9.0.18) - #3989
Merged
Merged
Conversation
The net8.0 block over-bumped System.Security.Cryptography.Xml/Pkcs to 9.0.18 on the assumption that no patched 8.0.x existed. Per the advisory (CVE-2026-47302, -47304, -50525, -50648), the patched System.Security.Cryptography.Xml for net8.0 is 8.0.4 (affected <=8.0.3); 8.0.29 is the .NET *runtime* patch, not this OOB package. Xml 8.0.4 depends on Pkcs 8.0.1, so pin Pkcs 8.0.1 (no NU1605). net9.0 (9.0.18) and net10.0 (10.0.10) are unchanged - those are correct for their lines. Validated: dotnet restore Microsoft.Identity.Web.sln => exit 0, net8.0 resolves Xml 8.0.4 / Pkcs 8.0.1. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: ba7e127a-a204-4fdc-8512-73fba660adcd
neha-bhargava
approved these changes
Jul 29, 2026
pmaytak
approved these changes
Jul 29, 2026
This was referenced Jul 30, 2026
Merged
Merged
Merged
Open
Merged
This was referenced Aug 2, 2026
Open
Open
Merged
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses @pmaytak's review: the net8.0 crypto floor should use the patched 8.0.x version, not a jump to
9.0.18.Problem
The net8.0 block set
System.Security.Cryptography.Xml/Pkcsto9.0.18, with a comment assuming no patched 8.0.x existed ("8.0.29 is unreleased"). That conflated the .NET runtime patch (8.0.29, forMicrosoft.NetCore.App.Runtime.*) with the OOB package. Per Microsoft Security Advisory CVE-2026-47302,System.Security.Cryptography.Xmlis affected>= 8.0.0, <= 8.0.3and patched in8.0.4.Fix (net8.0 block only)
Xml 8.0.4declares a dependency onPkcs 8.0.1(the highest published 8.0.x Pkcs), so pinning Pkcs8.0.1satisfies it with no NU1605. net9.0 (9.0.18) and net10.0 (10.0.10) are unchanged — those are the correct patched versions for their lines.Validation
dotnet restore Microsoft.Identity.Web.sln→ exit 0; net8.0 consumers resolve Xml 8.0.4 / Pkcs 8.0.1. Also running the cross-repo compat gate (builds the ID4S family + MISE) against this branch.