Enable E2E test coverage on internal Azure DevOps pipelines - #3883
Merged
Iarek Kovtunenko (iarekk) merged 3 commits intoJun 23, 2026
Conversation
Contributor
Author
Iarek Kovtunenko (iarekk)
approved these changes
Jun 22, 2026
Iarek Kovtunenko (iarekk)
force-pushed
the
gladjohn/remove-ignore-on-azdo
branch
from
June 22, 2026 10:18
16d6aca to
c40391b
Compare
Bogdan Gavril (bgavrilMS)
requested changes
Jun 22, 2026
Bogdan Gavril (bgavrilMS)
left a comment
Bogdan Gavril (bgavrilMS)
left a comment
Member
There was a problem hiding this comment.
Misleading class
Iarek Kovtunenko (iarekk)
force-pushed
the
gladjohn/remove-ignore-on-azdo
branch
from
June 22, 2026 13:18
4b53890 to
0a38932
Compare
Gladwin Johnson VR (gladjohn)
changed the title
Iarek Kovtunenko (iarekk)
approved these changes
Jun 22, 2026
Tests should run on self-hosted agents (MSALMSIV2) that have the required certificates and KeyVault access. Tests with explicit Skip reasons are unaffected (they set Skip in the attribute usage, not the constructor). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The class did nothing after the auto-skip logic was removed. Replace all usages with [Fact] (keeping explicit Skip reasons intact) and inline the env-var check into OnlyOnAzureDevopsFactAttribute. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Iarek Kovtunenko (iarekk)
force-pushed
the
gladjohn/remove-ignore-on-azdo
branch
from
June 22, 2026 15:58
0a38932 to
f1baa0b
Compare
Bogdan Gavril (bgavrilMS)
approved these changes
Jun 23, 2026
This was referenced Jun 24, 2026
Merged
Closed
Closed
This was referenced Jul 20, 2026
Closed
This was referenced Jul 27, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Open
Closed
This was referenced Aug 3, 2026
Closed
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the automatic skip behavior from
IgnoreOnAzureDevopsFactAttributeso that E2E tests run on self-hosted agents that have the required lab certificates and KeyVault access.Tests with explicit
Skipreasons (e.g., issue #2732, ephemeral tenant requirement) are unaffected — they setSkipat the usage site, not in the constructor.Motivation
These tests were being skipped on all Azure DevOps pipelines, but our self-hosted agents have the lab certificates (
CN=LabAuth.MSIDLab.com) and KeyVault access needed to run them successfully. This change enables full E2E test coverage in our internal pipelines.