Prevent OpenIdConnectMiddlewareDiagnostics from logging sensitive values - #3850
Merged
Merged
Conversation
iarekk
force-pushed
the
iarekk/redact-openidconnect-diagnostic-logging
branch
from
June 9, 2026 12:20
412468e to
51f0cdb
Compare
bgavrilMS
approved these changes
Jun 9, 2026
OpenIdConnectMiddlewareDiagnostics logs full protocol messages, including bearer tokens and PII, at Debug level. The middleware is opt-in via subscribeToOpenIdConnectMiddlewareDiagnosticsEvents, but the parameter gives no signal that flipping it in production leaks credentials. Register a hosted service whenever the caller opts in. On host startup it resolves IHostEnvironment and throws IDW10117 unless the environment is Development, aborting deployment before any HTTP request can trigger the diagnostic. The check fails closed: a missing IHostEnvironment is treated as non-Development. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
iarekk
force-pushed
the
iarekk/redact-openidconnect-diagnostic-logging
branch
from
June 9, 2026 13:48
51f0cdb to
d027f00
Compare
This was referenced Jun 24, 2026
Merged
Closed
Closed
Closed
Merged
This was referenced Jul 17, 2026
Closed
Closed
Closed
This was referenced Jul 27, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
This was referenced Aug 3, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The diagnostic is now built by a factory that throws
IDW10117unlessIHostEnvironment.IsDevelopment()returns true, so any authentication attempt outside Development fails before the handler can log the message.Supersedes #3847.