Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode string(japanese-strting) use atob is getting error . (Regression) #6476

Closed
magnet163 opened this issue Sep 14, 2023 · 5 comments
Closed
Assignees
Labels
bug-unconfirmed A reported bug that needs to be investigated and confirmed msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.

Comments

@magnet163
Copy link

Core Library

MSAL.js (@azure/msal-browser)

Core Library Version

3.1.0

Wrapper Library

MSAL Angular (@azure/msal-angular)

Wrapper Library Version

3.0.4

Public or Confidential Client?

Public

Description

The following error has recurred.
Since @azure/msal-browser 3.1.0, I am getting occasional errors when Japanese characters are included.
#985

Error Message

1694663603412.log

Msal Logs

No response

MSAL Configuration

auth: {
   clientId: "XXXXXX",
   authority: "https://login.microsoftonline.com/common/",
   redirectUri: "/auth/signin",
   postLogoutRedirectUri: "/auth/signin"
 },
 cache: {
   cacheLocation: BrowserCacheLocation.LocalStorage,
   storeAuthStateInCookie: false
 },
 system: {
   allowNativeBroker: false
 }

Relevant Code Snippets

import { CommonModule } from '@angular/common';
import { ChangeDetectionStrategy, Component, inject } from '@angular/core';
import { MsalService } from '@azure/msal-angular';

@Component({
  selector: 'app-signin',
  standalone: true,
  imports: [
    CommonModule,
  ],
  templateUrl: './signin.component.html',
  styleUrls: ['./signin.component.scss'],
  changeDetection: ChangeDetectionStrategy.OnPush
})
export class SigninComponent {
  readonly #msalService = inject(MsalService);

  constructor() {
    this.#msalService.handleRedirectObservable().subscribe();
  }

  signIn() {
    this.#msalService.loginPopup()
      .subscribe(res => {
      });
  }
}

Reproduction Steps

  1. Signin Japanese DisplayName account.
  2. Execute signIn method.

However, it does not always result in an error, and in rare cases it may succeed.

Expected Behavior

Non Error decode.

Identity Provider

Azure AD / MSA

Browsers Affected (Select all that apply)

Chrome, Firefox, Edge

Regression

@azure/msal-browser 3.0.2

Source

External (Customer)

@magnet163 magnet163 added bug-unconfirmed A reported bug that needs to be investigated and confirmed question Customer is asking for a clarification, use case or information. labels Sep 14, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Sep 14, 2023
@github-actions github-actions bot added msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications labels Sep 14, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @hectormmg please follow up.

@microsoft-github-policy-service
Copy link
Contributor

This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @hectormmg please follow up.

@microsoft-github-policy-service
Copy link
Contributor

This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @hectormmg please follow up.

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @hectormmg please follow up.

@tnorling
Copy link
Collaborator

tnorling commented Oct 9, 2023

This has been fixed in version 3.2.0

@tnorling tnorling closed this as completed Oct 9, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-unconfirmed A reported bug that needs to be investigated and confirmed msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.
Projects
None yet
Development

No branches or pull requests

3 participants