-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
performanceMeasurement.startMeasurement is not a function Error in Type script sample #5587
Comments
Facing the same issue. Kindly let us know when can this be fixed or any other workarounds. |
Having the same issue with my Angular app (@azure/msal-browser": "^2.28.0)
|
Just updated my angular app and got the same problem. |
is there going to be any fix for this? or a workaround? |
Should we roll back a version here? We have: a.startMeasurement is not a function |
|
Can confirm that this is happening to our latest deploys as well. We're using:
And getting the following issue:
Thing to note is the number 2 added to the names of PerformanceClient2, BrowserPerformanceClient2 etc. Any pointers or workarounds would be much appreciated! Thanks a lot in advance! // G |
We did a rollback and app is running fine. |
For Angular I used those two versions to make it work again: |
In React we did a rollback in |
Thank you! Been banging my head against the wall 😅 |
The issue was really caused by us using the non explicit versioning for msal-browser. Just remember to use explicit versioning and target version Most likely the cause that is making this issue emerge. Thanks for all the help in this thread! |
@jo-arroyo it seems you updated PerformanceClient but it didn't fixed yet please confirm |
@jo-arroyo whats the status on this issue? |
Doesn't look like the PR has been merged yet if you look at #5589. Looks like code reviews are still being performed. |
For now this is the temporary solution until they proper fix. Just use it without
|
For me, the following versions worked in Angular. "@azure/msal-angular": "2.5.1",
"@azure/msal-browser": "2.32.1", |
Hi all, yes this is a confirmed bug that we are working on fixing. Please downgrade until the next release is available. |
First a breaking defect in the App Insights SDK and then this... Were all the Azure JS testers part of the layoffs this week? |
Thank you all for your patience. Msal-common v 9.1.1 has been released. Please upgrade and let us know if you continue to see issues. |
Closing as msal-common v9.1.1 release addresses these issues. Please open a new issue if you continue to see errors. |
Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
1.4.9
Wrapper Library
MSAL React (@azure/msal-react)
Wrapper Library Version
1.4.9
Public or Confidential Client?
Public
Description
Getting issue with type script sample path for sample download :microsoft-authentication-library-for-js-dev\samples\msal-react-samples\typescript-sample, cloud not able to proceed further with type script sample , dont know how to fix this error
Error Message
error details Uncaught TypeError: performanceMeasurement.startMeasurement is not a function
at PerformanceClient.startMeasurement (PerformanceClient.ts:123:1)
at BrowserPerformanceClient.startMeasurement (BrowserPerformanceClient.ts:46:1)
at ClientApplication.acquireTokenPopup (ClientApplication.ts:328:1)
at PublicClientApplication.loginPopup (PublicClientApplication.ts:84:1)
at handleLogin (SignInButton.tsx:18:1)
at onClick (SignInButton.tsx:47:1)
at HTMLUnknownElement.callCallback (react-dom.development.js:4164:1)
at Object.invokeGuardedCallbackDev (react-dom.development.js:4213:1)
at invokeGuardedCallback (react-dom.development.js:4277:1)
at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:4291:1)
Please let me know how to fix this issue as soon as possible
Msal Logs
n/a
MSAL Configuration
Relevant Code Snippets
Reproduction Steps
n/a
Expected Behavior
n/a
Identity Provider
Azure AD / MSA
Browsers Affected (Select all that apply)
Chrome
Regression
@azure/msal-browser": "^2.30.0"
Source
Internal (Microsoft)
The text was updated successfully, but these errors were encountered: