Problem with msal-browser v2.32.2 on safari

[kbartyzel]

Core Library

MSAL.js v2 (@azure/msal-browser)

Core Library Version

2.32.2

Wrapper Library

MSAL Angular (@azure/msal-angular)

Wrapper Library Version

"@azure/msal-react": "1.5.1"

Public or Confidential Client?

Public

Description

We have exceptions

• Unhandled Promise Rejection: SyntaxError: Invalid regular expression: invalid group specifier name
• SyntaxError: Invalid regular expression: invalid group specifier name
  and few others after updating to the new package. Yesterday everything was working.

Previously working version was
"@azure/msal-common" : "9.0.1",
"@azure/msal-browser": "2.32.1",
"@azure/msal-react": "1.5.1",

Error Message

No response

Msal Logs

No response

MSAL Configuration

confidential - but correct, works for months

Relevant Code Snippets

The token is valid, everything is configured correctly

Reproduction Steps

Open a page
Start to log in
After login, redirect back to the original page, we have an exception

Expected Behavior

Token is valid, everything is configured correctly

Identity Provider

Azure AD / MSA

Browsers Affected (Select all that apply)

Safari

Regression

@azure/msal-browser": "2.32.1

Source

Internal (Microsoft)

[kbartyzel]

[SimoNDeviL]

From version
"@azure/msal-common" : "9.0.2",
problems begins on Chrome, Edge, Firefox and Safari.

[submarines-and]

Same issue for us.

Could it be this commit?
29701fa

As I recall, Safari does not have support for lookbehind.

Sorry if I am way off, take this with a grain of salt :)

[hectormmg]

Thanks for raising the issue @kbartyzel . We'll look into it and provide updates here. For now, please downgrade to 2.32.1 if that's possible.

[SimonGolms]

Just a simple downgrade to the previous versions of @azure/msal-browser@2.32.1 and @azure/msal-react@1.5.1 will not work, because the dependency @azure/msal-common is not specified as a strict version here:

microsoft-authentication-library-for-js/lib/msal-browser/package.json

Lines 92 to 94 in 4ba6eb3

	"dependencies": {
	"@azure/msal-common": "^9.0.1"
	}

So even with a new install, the latest (and corrupt) version of @azure/msal-common@9.0.2 will be installed, because it is compatible according to semver specification.

With npm, I fixed it with the overrides configuration in my package.json

{
  "dependencies": {
    "@azure/msal-browser": "2.32.1",
    "@azure/msal-react": "1.5.1",
  },
  "overrides": {
    "@azure/msal-common": "9.0.1"
  }
}

[Webbwhite98]

Just a simple downgrade to the previous versions of @azure/msal-browser@2.32.1 and @azure/msal-react@1.5.1 will not work, because the dependency @azure/msal-common is not specified as a strict version here:

microsoft-authentication-library-for-js/lib/msal-browser/package.json

Lines 92 to 94 in 4ba6eb3

	"dependencies": {
	"@azure/msal-common": "^9.0.1"
	}

So even with a new install, the latest (and corrupt) version of @azure/msal-common@9.0.2 will be installed, because it is compatible according to semver specification.

With npm, I fixed it with the overrides configuration in my package.json

{
  "dependencies": {
    "@azure/msal-browser": "2.32.1",
    "@azure/msal-react": "1.5.1",
  },
  "overrides": {
    "@azure/msal-common": "9.0.1"
  }
}

This worked for me, I also had to add @azure/msal-common": "9.0.1" as a dependency

[mkosir]

Just a simple downgrade to the previous versions of @azure/msal-browser@2.32.1 and @azure/msal-react@1.5.1 will not work, because the dependency @azure/msal-common is not specified as a strict version here:

microsoft-authentication-library-for-js/lib/msal-browser/package.json

Lines 92 to 94 in 4ba6eb3

	"dependencies": {
	"@azure/msal-common": "^9.0.1"
	}

So even with a new install, the latest (and corrupt) version of @azure/msal-common@9.0.2 will be installed, because it is compatible according to semver specification.

Thanks for pointing this out, this is really useful info 🙇‍♂️
Initially we did a rollback of @azure/msal-browser (without overrides config) and the error still persisted.

I think the dependency @azure/msal-common should be fixed, to prevent this kind of issues in the future (as also other related dependencies). Otherwise results can be messy for devs since it depends "when" you install MSAL package.

[aso1datov]

If you are using yarn use resolutions instead.

"dependencies": {
    "@azure/msal-browser": "2.32.1",
    "@azure/msal-common": "9.0.1",
    "@azure/msal-react": "1.5.1",
}
"resolutions": {
    "@azure/msal-common": "9.0.1"
 }