Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'MsalModule' does not appear to be an NgModule class #5336

Closed
johnvinosh opened this issue Oct 26, 2022 · 9 comments
Closed

'MsalModule' does not appear to be an NgModule class #5336

johnvinosh opened this issue Oct 26, 2022 · 9 comments
Assignees
Labels
answered Question has received "first qualified response" bug-unconfirmed A reported bug that needs to be investigated and confirmed msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package no-issue-activity Issue author has not responded in 5 days public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.

Comments

@johnvinosh
Copy link

Core Library

MSAL.js v2 (@azure/msal-browser)

Core Library Version

2.30.0

Wrapper Library

MSAL Angular (@azure/msal-angular)

Wrapper Library Version

2.4.5

Public or Confidential Client?

Public

Description

image

I am getting this compile time error when I import MsalModule

Error Message

'MsalModule' does not appear to be an NgModule class.(-996002)
msal.module.d.ts(7, 19): This likely means that the library (@azure/msal-angular) which declares MsalModule has not been processed correctly by ngcc, or is not compatible with Angular Ivy. Check if a newer version of the library is available, and update if so. Also consider checking with the library's authors to see if the library is expected to be compatible with Ivy.

Msal Logs

No response

MSAL Configuration

auth: {
    clientId: '',
    authority: '',
    navigateToLoginRequestUrl: true,
    redirectUri: '',
  },

Relevant Code Snippets

@NgModule({
  imports: [
    MsalModule,
  ],
  declarations: [AppComponent],
  bootstrap: [AppComponent],
})
export class AppModule {}

Reproduction Steps

Just import MsalModule

Expected Behavior

No compile Time error

Identity Provider

Azure AD / MSA

Browsers Affected (Select all that apply)

Chrome, Firefox, Edge, Safari, Internet Explorer

Regression

No response

Source

External (Customer)

@johnvinosh johnvinosh added bug-unconfirmed A reported bug that needs to be investigated and confirmed question Customer is asking for a clarification, use case or information. labels Oct 26, 2022
@ghost ghost added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Oct 26, 2022
@github-actions github-actions bot added msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications labels Oct 26, 2022
@ghost ghost assigned bmahall Oct 26, 2022
@bmahall
Copy link
Contributor

bmahall commented Oct 26, 2022

@johnvinosh Thanks for opening this issue, it is currently being tracked in #4298 . You can find the Roadmap here.

Can you include the Angular version you are using as well?

@ghost ghost added answered Question has received "first qualified response" Needs: Author Feedback Awaiting response from issue author and removed Needs: Attention 👋 Awaiting response from the MSAL.js team labels Oct 26, 2022
@ghost
Copy link

ghost commented Nov 1, 2022

@johnvinosh This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale.

@ghost ghost added the no-issue-activity Issue author has not responded in 5 days label Nov 1, 2022
@bmahall
Copy link
Contributor

bmahall commented Nov 2, 2022

@johnvinosh Closing this as duplicate of #4298.

@bmahall bmahall closed this as completed Nov 2, 2022
@ghost ghost removed the Needs: Author Feedback Awaiting response from issue author label Nov 2, 2022
@spock123
Copy link

spock123 commented Dec 29, 2022

I can add that I have this issue with Angular v15.0.4, using EsBuild.
It works fine with the standard builder.

Thanks

@SGeorge007
Copy link

I can confirm too , the issue is there with angular v14

@kenstanley37
Copy link

Same issue with Angular v16

@SebastianBaiju
Copy link

yes it is in the angular v16

@dansau84
Copy link

where is the solution ???? why too long for this or temporary workaround ?

@Taats
Copy link

Taats commented May 24, 2023

look here: #4298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered Question has received "first qualified response" bug-unconfirmed A reported bug that needs to be investigated and confirmed msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package no-issue-activity Issue author has not responded in 5 days public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.
Projects
None yet
Development

No branches or pull requests

8 participants