Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken link for initializing application object #5251

Closed
PeterArriaza opened this issue Sep 30, 2022 · 1 comment
Closed

broken link for initializing application object #5251

PeterArriaza opened this issue Sep 30, 2022 · 1 comment
Assignees
Labels
answered Question has received "first qualified response" documentation Related to documentation. msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.

Comments

@PeterArriaza
Copy link

Core Library

MSAL.js v2 (@azure/msal-browser)

Wrapper Library

MSAL Angular (@azure/msal-angular)

Public or Confidential Client?

Public

Documentation Location

https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-angular/docs/v2-docs/public-apis.md

Description

The first link for how to initialize the application object is broken. It seems like there are multiple ways of doing this, so I'd like to make sure that I'm doing the right thing.
I'm using Angular 11 and the v11 docs show one way: https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/samples/msal-angular-v2-samples/angular11-sample-app/src/app/app.module.ts whereas the general v2 docs I have linked shows another way.

@PeterArriaza PeterArriaza added documentation Related to documentation. question Customer is asking for a clarification, use case or information. labels Sep 30, 2022
@ghost ghost added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Sep 30, 2022
@github-actions github-actions bot added msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications labels Sep 30, 2022
@ghost ghost assigned hectormmg Sep 30, 2022
@hectormmg
Copy link
Member

@PeterArriaza thanks for raising this issue. I've made a PR with updates to fix the broken angular doc references. As for how to initialize an MSAL Angular instance, I suggest you follow the v2 docs since those are updated more regularly than the dev samples for older versions of Angular. Please let us know if you have any other questions!

@ghost ghost added answered Question has received "first qualified response" Needs: Author Feedback Awaiting response from issue author and removed Needs: Attention 👋 Awaiting response from the MSAL.js team labels Oct 4, 2022
@ghost ghost removed the Needs: Author Feedback Awaiting response from issue author label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered Question has received "first qualified response" documentation Related to documentation. msal-angular Related to @azure/msal-angular package msal-browser Related to msal-browser package public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.
Projects
None yet
Development

No branches or pull requests

2 participants