-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox stuck in login loop #5118
Comments
I have to say these loops have been a common thing for MSAL since it's release. Maybe you could look into implementing better tools to detect them (and gather the metrics needed to understand them) and if possible automatically try to fix them, like trying to clear the storages. |
@eluchsinger thanks for the suggestion and for opening the issue. Was this loop something that was only seen once and fixed by clearing storage and cookies? Or has it been noticed by multiple users? |
@eluchsinger This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale. |
@hectormmg it was experienced by multiple users. All on Firefox and probably had not used the login in a while (could both be coincidence of course). |
@eluchsinger could you show us what you're passing in your app-routing.module.ts so we can see how your app implements reidrects? |
@hectormmg of course. This is what we are doing in the app-routing: import { NgModule } from "@angular/core";
import { Routes, RouterModule } from "@angular/router";
import { IndexComponent } from "./index/index.component";
import { MsalGuard } from "@azure/msal-angular";
import { BrowserUtils } from "@azure/msal-browser";
const routes: Routes = [
{
path: "",
component: IndexComponent,
},
{
path: "b2b",
loadChildren: () => import("./b2b/b2b.module").then((m) => m.B2bModule),
canActivate: [MsalGuard],
},
];
@NgModule({
imports: [
RouterModule.forRoot(routes, {
initialNavigation:
!BrowserUtils.isInIframe() && !BrowserUtils.isInPopup()
? "enabledNonBlocking"
: "disabled", // Set to enabledBlocking to use Angular Universal
}),
],
exports: [RouterModule],
})
export class AppRoutingModule {} |
This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @hectormmg please follow up. |
4 similar comments
This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @hectormmg please follow up. |
This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @hectormmg please follow up. |
This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @hectormmg please follow up. |
This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @hectormmg please follow up. |
This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @hectormmg please follow up. |
@eluchsinger Picking up this issue. Have you continued to see this behavior since the last comment? If so, are you able to get verbose logs and a network trace? We have thus far been unable to reproduce this behavior on our end. |
@jo-arroyo I haven't heard of any further problems. I think we can close this issue. Thanks! |
Core Library
MSAL.js v2 (@azure/msal-browser)
Core Library Version
2.28.1
Wrapper Library
MSAL Angular (@azure/msal-angular)
Wrapper Library Version
2.4.1
Public or Confidential Client?
Public
Description
On Firefox we are noticing a redirection loop when trying to login. This stops from happening after clearing the cookies & cache.
Error Message
The only errors I get is an HTTP
400
from AAD B2C and the error below from MSAL:@azure/msal-angular@2.4.1 : Error - Interceptor - acquireTokenSilent rejected with error. Invoking interaction to resolve.
Msal Logs
Sorry. Can't do, because I can not reproduce the behavior after clearing the cookies once.
MSAL Configuration
Relevant Code Snippets
None
Reproduction Steps
MsalGuard
using FirefoxExpected Behavior
Go to the login screen or serve the guarded route if already logged in.
Identity Provider
Azure B2C Basic Policy
Browsers Affected (Select all that apply)
Firefox
Regression
No response
Source
External (Customer)
The text was updated successfully, but these errors were encountered: