Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support query response mode for login redirect flow #5117

Closed
japem opened this issue Aug 18, 2022 · 9 comments
Closed

Support query response mode for login redirect flow #5117

japem opened this issue Aug 18, 2022 · 9 comments
Assignees
Labels
answered Question has received "first qualified response" feature-unconfirmed msal-browser Related to msal-browser package msal-react Related to @azure/msal-react public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.

Comments

@japem
Copy link

japem commented Aug 18, 2022

Core Library

MSAL.js v2 (@azure/msal-browser)

Wrapper Library

MSAL React (@azure/msal-react)

Public or Confidential Client?

Public

Description

This is a rehash of #2228, but that issue is locked and I can't comment.

I have a specific use case for wanting this feature - I have a single public client used for many different hosts, and rather than configuring each one to be an allowed redirect URL for my client I would like to be able to set up a single host as a proxy and have that itself perform a redirect to the site that initiated the flow. This is not possible with the response mode set to fragment, since it is stripped from the request before being sent to the server.

Source

External (Customer)

@japem japem added feature-unconfirmed question Customer is asking for a clarification, use case or information. labels Aug 18, 2022
@ghost ghost added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Aug 18, 2022
@github-actions github-actions bot added msal-browser Related to msal-browser package msal-react Related to @azure/msal-react public-client Issues regarding PublicClientApplications labels Aug 18, 2022
@ghost ghost assigned hectormmg Aug 18, 2022
@hectormmg
Copy link
Member

@japem thanks for the request. There are currently no plans to support other response modes as the documentation update referenced in the issue states. I'll still bring your use case to the team and I'll update this issue with the results of the discussion. Thanks again!

@ghost ghost added answered Question has received "first qualified response" Needs: Author Feedback Awaiting response from issue author and removed Needs: Attention 👋 Awaiting response from the MSAL.js team labels Aug 22, 2022
@peterzenz peterzenz assigned peterzenz and EmLauber and unassigned hectormmg and peterzenz Aug 22, 2022
@peterzenz
Copy link
Contributor

@EmLauber might be worth understanding the use case here.

@jasonnutter
Copy link
Contributor

and rather than configuring each one to be an allowed redirect URL for my client I would like to be able to set up a single host as a proxy and have that itself perform a redirect to the site that initiated the flow

Would the auth requests start on one domain and end on another?

@japem
Copy link
Author

japem commented Aug 22, 2022

and rather than configuring each one to be an allowed redirect URL for my client I would like to be able to set up a single host as a proxy and have that itself perform a redirect to the site that initiated the flow

Would the auth requests start on one domain and end on another?

Yes, as far as AD FS is concerned it is receiving a request from one domain and then redirecting to another. However ultimately the flow would end on the domain that started it after being proxied through the server hosted at the redirect URL.

@ghost ghost added Needs: Attention 👋 Awaiting response from the MSAL.js team and removed Needs: Author Feedback Awaiting response from issue author labels Aug 22, 2022
@jasonnutter
Copy link
Contributor

@japem Okay, thanks. I don't think that is something our library can support, as the SDK needs to be able to validate the request, which is does by storing temporary pieces of state in browser storage (session storage, usually) on the origin which initiated the request (and due to the same-origin policy, those pieces of state will not be accessible on another origin).

@ghost ghost added Needs: Author Feedback Awaiting response from issue author and removed Needs: Attention 👋 Awaiting response from the MSAL.js team labels Aug 23, 2022
@japem
Copy link
Author

japem commented Aug 23, 2022

I don't think that is something our library can support, as the SDK needs to be able to validate the request

I’m not looking to use MSAL on this other host, though, so I don’t need it to validate anything for me. I’m looking to implement the remainder of the authorization code flow myself.

@ghost ghost added Needs: Attention 👋 Awaiting response from the MSAL.js team and removed Needs: Author Feedback Awaiting response from issue author labels Aug 23, 2022
@japem
Copy link
Author

japem commented Aug 23, 2022

Or, alternatively I could have my server redirect to the same host as I initiated the flow from with a 3xx status code. In this case I would use MSAL to perform the rest of the authorization code flow, but from the same origin it initiated from, and I believe all session storage should be available depending on the cache type I use. (This seems like it should just work but I’m not sure.)

@ghost
Copy link

ghost commented Aug 29, 2022

This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @EmLauber please follow up.

@peterzenz
Copy link
Contributor

This isn't a scenario we'd support in our library where we'd only handle part of the auth code flow with you implementing the other part. The code we have is here and you're welcome to use it, but it's not a scenario we'd build or support.

@ghost ghost removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered Question has received "first qualified response" feature-unconfirmed msal-browser Related to msal-browser package msal-react Related to @azure/msal-react public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.
Projects
None yet
Development

No branches or pull requests

5 participants