Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User is not redirected to redirect uri on mobile #5111

Closed
1hw7 opened this issue Aug 17, 2022 · 26 comments
Closed

User is not redirected to redirect uri on mobile #5111

1hw7 opened this issue Aug 17, 2022 · 26 comments
Assignees
Labels
answered Question has received "first qualified response" bug-unconfirmed A reported bug that needs to be investigated and confirmed msal-browser Related to msal-browser package msal-react Related to @azure/msal-react public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.

Comments

@1hw7
Copy link

1hw7 commented Aug 17, 2022

Core Library

MSAL.js v2 (@azure/msal-browser)

Core Library Version

2.24.0

Wrapper Library

MSAL React (@azure/msal-react)

Wrapper Library Version

1.4.0

Public or Confidential Client?

Public

Description

On mobile (safari and edge) when a user logs out, it hangs on the "you have logged out page" and the redirect uri does not seem to be triggered (user is never redirected to redirect uri)

Error Message

No response

Msal Logs

No response

MSAL Configuration

auth: {
        clientId: config.auth.clientId,
        authority: 'https://login.microsoftonline.com/consumers',
        redirectUri: `${config.auth.redirectUrl || config.sasUrl}/home`,
        navigateToLoginRequestUrl: false,
        postLogoutRedirectUri: `${config.auth.redirectUrl || config.sasUrl}`,
    },
    cache: {
        cacheLocation: BrowserCacheLocation.SessionStorage,
    }

Relevant Code Snippets

used button click to trigger signout, used instance.logoutredirect on button click

Reproduction Steps

  1. Open safari on mobile
  2. Click sign out button
  3. User is signed out, but never redirected back to redirect uri

Expected Behavior

User should be redirected to redirect uri

Identity Provider

Azure AD / MSA

Browsers Affected (Select all that apply)

Edge, Safari

Regression

No response

Source

Internal (Microsoft)

@1hw7 1hw7 added bug-unconfirmed A reported bug that needs to be investigated and confirmed question Customer is asking for a clarification, use case or information. labels Aug 17, 2022
@ghost ghost added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Aug 17, 2022
@github-actions github-actions bot added msal-browser Related to msal-browser package msal-react Related to @azure/msal-react public-client Issues regarding PublicClientApplications labels Aug 17, 2022
@ghost ghost assigned hectormmg Aug 17, 2022
@hectormmg
Copy link
Member

hectormmg commented Aug 17, 2022

@1hw7 is the postLogoutRedirectUri registered as a redirect URL and Logout URL in your app registration?

Here's the three requirements for successful redirection after logout:

  1. Pass a postLogoutRedirectUri to logout
  2. Register this url as a redirectUri on the app registration

Check out the MSAL Logout docs for more details.

@ghost ghost added answered Question has received "first qualified response" Needs: Author Feedback Awaiting response from issue author and removed Needs: Attention 👋 Awaiting response from the MSAL.js team labels Aug 17, 2022
@1hw7
Copy link
Author

1hw7 commented Aug 17, 2022

Thanks for your help Hector! Yes, it is and this works for us in desktop. The issue only arises on a mobile device
edit: actually, it's possible we didn't configure this correctly! sorry, double checking now. Thank you!

@1hw7 1hw7 closed this as completed Aug 17, 2022
@1hw7 1hw7 reopened this Aug 17, 2022
@ghost ghost removed the Needs: Author Feedback Awaiting response from issue author label Aug 17, 2022
@1hw7
Copy link
Author

1hw7 commented Aug 23, 2022

We confirmed that our implementation follows the docs you linked Hector (thank you!) so we are awaiting further context on what the error is and how we can solve this problem

@1hw7
Copy link
Author

1hw7 commented Sep 12, 2022

To update: user is not actually signed out and the user is sso'd back into the app. It seems the server session is not ended?

@hectormmg hectormmg assigned sameerag and unassigned hectormmg Sep 14, 2022
@sameerag
Copy link
Member

Can we please get the msal and network logs @1hw7?

@ghost ghost added the Needs: Author Feedback Awaiting response from issue author label Sep 19, 2022
@ghost
Copy link

ghost commented Sep 24, 2022

@1hw7 This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale.

@ghost ghost added the no-issue-activity Issue author has not responded in 5 days label Sep 24, 2022
@sameerag
Copy link
Member

Keeping this active. The team reached out to me offline and provided the needed information.

@ghost ghost closed this as completed Oct 6, 2022
@tadeas22
Copy link

tadeas22 commented Oct 13, 2022

Same problem for me, please reopen

@gatsby-david
Copy link

gatsby-david commented Oct 13, 2022

For me, the bug is happening only in Chrome on mobile. FF is ok.

@1hw7
Copy link
Author

1hw7 commented Oct 14, 2022

Hi @sameerag could we please reopen this issue(edit: i didn't realize my comment would reopen sorry!)? i do not think the issue has been resolved on our end

@ghost ghost reopened this Oct 14, 2022
@ghost ghost added the Needs: Attention 👋 Awaiting response from the MSAL.js team label Oct 14, 2022
@ghost ghost added Needs: Author Feedback Awaiting response from issue author and removed Needs: Attention 👋 Awaiting response from the MSAL.js team labels Oct 26, 2022
@sameerag sameerag removed their assignment Oct 26, 2022
@bmahall
Copy link
Contributor

bmahall commented Oct 26, 2022

@1hw7 I am in touch with @sameerag and will get back on this on priority. Thanks

@bmahall
Copy link
Contributor

bmahall commented Oct 27, 2022

@1hw7 Please share logs on the email mentioned on my profile if possible , looking forward to chat on Monday when you are next available.

@ghost
Copy link

ghost commented Nov 2, 2022

@1hw7 This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale.

@ghost ghost added the no-issue-activity Issue author has not responded in 5 days label Nov 2, 2022
@1hw7
Copy link
Author

1hw7 commented Nov 3, 2022

Commenting to leave open, as the issue continues to persist

@ghost ghost added Needs: Attention 👋 Awaiting response from the MSAL.js team and removed Needs: Author Feedback Awaiting response from issue author no-issue-activity Issue author has not responded in 5 days labels Nov 3, 2022
@ghost
Copy link

ghost commented Nov 9, 2022

This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @bmahall please follow up.

1 similar comment
@ghost
Copy link

ghost commented Nov 14, 2022

This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @bmahall please follow up.

@peterzenz peterzenz assigned tnorling and unassigned bmahall Nov 14, 2022
@ghost
Copy link

ghost commented Nov 20, 2022

This issue requires attention from the MSAL.js team and has not seen activity in 5 days. @tnorling please follow up.

@sameerag
Copy link
Member

@1hw7 Are we still stuck on this?

@ghost ghost added Needs: Author Feedback Awaiting response from issue author and removed Needs: Attention 👋 Awaiting response from the MSAL.js team labels Nov 21, 2022
@ghost
Copy link

ghost commented Nov 27, 2022

@1hw7 This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale.

@ghost ghost added the no-issue-activity Issue author has not responded in 5 days label Nov 27, 2022
@ghost ghost closed this as completed Dec 4, 2022
@1hw7
Copy link
Author

1hw7 commented Dec 14, 2022

@sameerag sorry i missed your comment! Thomas was able to help us look into it (thank you Thomas!). He gave us some insight on what might be going wrong on our end, we really appreciate the help!

@ghost ghost reopened this Dec 14, 2022
@ghost ghost added Needs: Attention 👋 Awaiting response from the MSAL.js team and removed no-issue-activity Issue author has not responded in 5 days Needs: Author Feedback Awaiting response from issue author labels Dec 14, 2022
@ghost ghost removed the Needs: Attention 👋 Awaiting response from the MSAL.js team label Dec 14, 2022
@asimyaramis
Copy link

can u describe what is causing the error and how u solved? @1hw7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answered Question has received "first qualified response" bug-unconfirmed A reported bug that needs to be investigated and confirmed msal-browser Related to msal-browser package msal-react Related to @azure/msal-react public-client Issues regarding PublicClientApplications question Customer is asking for a clarification, use case or information.
Projects
None yet
Development

No branches or pull requests

8 participants