Merge pull request #5531 from AzureAD/fix-typos-telemetry-dev

Fix typos in telemetry

Author: bmahall

change/@azure-msal-browser-8b9a5a83-4741-4713-8aa4-4b4cd1fce136.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix typos #5531",
+  "packageName": "@azure/msal-browser",
+  "email": "bmahal@microsoft.com",
+  "dependentChangeType": "patch"
+}

change/@azure-msal-common-fd3e0f2f-07fa-4c4f-8c07-622199816ab9.json

@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "fix typos #5531",
+  "packageName": "@azure/msal-common",
+  "email": "bmahal@microsoft.com",
+  "dependentChangeType": "patch"
+}

lib/msal-browser/src/app/PublicClientApplication.ts

@@ -177,7 +177,7 @@ export class PublicClientApplication extends ClientApplication implements IPubli
      */
     protected async acquireTokenSilentAsync(request: SilentRequest, account: AccountInfo): Promise<AuthenticationResult>{
         this.eventHandler.emitEvent(EventType.ACQUIRE_TOKEN_START, InteractionType.Silent, request);
-        const astsAsyncMeasurement = this.performanceClient.startMeasurement(PerformanceEvents.AcquireTokenSilentAsync, request.correlationId);
+        const atsAsyncMeasurement = this.performanceClient.startMeasurement(PerformanceEvents.AcquireTokenSilentAsync, request.correlationId);
 
         let result: Promise<AuthenticationResult>;
         if (NativeMessageHandler.isNativeAvailable(this.config, this.logger, this.nativeExtensionProvider, request.authenticationScheme) && account.nativeAccountId) {
@@ -242,7 +242,7 @@ export class PublicClientApplication extends ClientApplication implements IPubli
 
         return result.then((response) => {
             this.eventHandler.emitEvent(EventType.ACQUIRE_TOKEN_SUCCESS, InteractionType.Silent, response);
-            astsAsyncMeasurement.endMeasurement({
+            atsAsyncMeasurement.endMeasurement({
                 success: true,
                 fromCache: response.fromCache,
                 isNativeBroker: response.fromNativeBroker,
@@ -251,7 +251,7 @@ export class PublicClientApplication extends ClientApplication implements IPubli
             return response;
         }).catch((tokenRenewalError: AuthError) => {
             this.eventHandler.emitEvent(EventType.ACQUIRE_TOKEN_FAILURE, InteractionType.Silent, null, tokenRenewalError);
-            astsAsyncMeasurement.endMeasurement({
+            atsAsyncMeasurement.endMeasurement({
                 errorCode: tokenRenewalError.errorCode,
                 subErrorCode: tokenRenewalError.subError,
                 success: false

lib/msal-browser/src/telemetry/BrowserPerformanceClient.ts

@@ -19,7 +19,7 @@ export class BrowserPerformanceClient extends PerformanceClient implements IPerf
         this.guidGenerator = new GuidGenerator(this.browserCrypto);
     }
 
-    startPerformanceMeasuremeant(measureName: string, correlationId: string): IPerformanceMeasurement {
+    startPerformanceMeasurement(measureName: string, correlationId: string): IPerformanceMeasurement {
         return new BrowserPerformanceMeasurement(measureName, correlationId);
     }
 

lib/msal-browser/test/telemetry/BrowserPerformanceClient.spec.ts

@@ -40,7 +40,7 @@ describe("BrowserPerformanceClient.ts", () => {
             expect(typeof browserPerfClient.generateId()).toBe("string");
         });
     });
-    describe("startPerformanceMeasuremeant", () => {
+    describe("startPerformanceMeasurement", () => {
         it("calculate performance duration", () => {
             const browserPerfClient = new BrowserPerformanceClient(clientId, authority, logger, name, version, applicationTelemetry, cryptoOptions);
 

lib/msal-common/src/telemetry/performance/IPerformanceClient.ts

@@ -26,6 +26,6 @@ export interface IPerformanceClient {
     removePerformanceCallback(callbackId: string): boolean;
     addPerformanceCallback(callback: PerformanceCallbackFunction): string;
     emitEvents(events: PerformanceEvent[], correlationId: string): void;
-    startPerformanceMeasuremeant(measureName: string, correlationId: string): IPerformanceMeasurement;
+    startPerformanceMeasurement(measureName: string, correlationId: string): IPerformanceMeasurement;
     generateId(): string;
 }

lib/msal-common/src/telemetry/performance/PerformanceClient.ts

@@ -72,7 +72,7 @@ export abstract class PerformanceClient implements IPerformanceClient {
      * @param {string} correlationId
      * @returns {IPerformanceMeasurement}
      */
-    abstract startPerformanceMeasuremeant(measureName: string, correlationId: string): IPerformanceMeasurement;
+    abstract startPerformanceMeasurement(measureName: string, correlationId: string): IPerformanceMeasurement;
 
     /**
      * Generates and returns a unique id, typically a guid.
@@ -97,7 +97,7 @@ export abstract class PerformanceClient implements IPerformanceClient {
         }
 
         this.logger.trace(`PerformanceClient: Performance measurement started for ${measureName}`, eventCorrelationId);
-        const performanceMeasurement = this.startPerformanceMeasuremeant(measureName, eventCorrelationId);
+        const performanceMeasurement = this.startPerformanceMeasurement(measureName, eventCorrelationId);
         performanceMeasurement.startMeasurement();
 
         const inProgressEvent: PerformanceEvent = {

lib/msal-common/src/telemetry/performance/StubPerformanceClient.ts

@@ -23,7 +23,7 @@ export class StubPerformanceClient extends PerformanceClient implements IPerform
         return "callback-id";
     }
 
-    startPerformanceMeasuremeant(): IPerformanceMeasurement {
+    startPerformanceMeasurement(): IPerformanceMeasurement {
         return new StubPerformanceMeasurement();
     }
 }

lib/msal-common/test/client/AuthorizationCodeClient.spec.ts

@@ -2017,7 +2017,7 @@ describe("AuthorizationCodeClient unit tests", () => {
                 removePerformanceCallback: jest.fn(),
                 addPerformanceCallback: jest.fn(),
                 emitEvents: jest.fn(),
-                startPerformanceMeasuremeant: jest.fn(),
+                startPerformanceMeasurement: jest.fn(),
                 generateId: jest.fn()
             }
             performanceClient.startMeasurement.mockImplementation(() => {
@@ -2071,7 +2071,7 @@ describe("AuthorizationCodeClient unit tests", () => {
                 removePerformanceCallback: jest.fn(),
                 addPerformanceCallback: jest.fn(),
                 emitEvents: jest.fn(),
-                startPerformanceMeasuremeant: jest.fn(),
+                startPerformanceMeasurement: jest.fn(),
                 generateId: jest.fn()
             }
             performanceClient.startMeasurement.mockImplementation(() => {

lib/msal-common/test/client/RefreshTokenClient.spec.ts

@@ -504,7 +504,7 @@ describe("RefreshTokenClient unit tests", () => {
                 removePerformanceCallback: jest.fn(),
                 addPerformanceCallback: jest.fn(),
                 emitEvents: jest.fn(),
-                startPerformanceMeasuremeant: jest.fn(),
+                startPerformanceMeasurement: jest.fn(),
                 generateId: jest.fn()
             }
             performanceClient.startMeasurement.mockImplementation(() => {
@@ -536,7 +536,7 @@ describe("RefreshTokenClient unit tests", () => {
                 removePerformanceCallback: jest.fn(),
                 addPerformanceCallback: jest.fn(),
                 emitEvents: jest.fn(),
-                startPerformanceMeasuremeant: jest.fn(),
+                startPerformanceMeasurement: jest.fn(),
                 generateId: jest.fn()
             }
             performanceClient.startMeasurement.mockImplementation(() => {