Improve behavior related to assertions #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/Authority.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Neha Bhargava <61847233+neha-bhargava@users.noreply.github.com>
…ntials # Conflicts: # msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/ClientCredentialTest.java
… avdunn/improve-credentials
This was referenced Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes behavior related to assertions in two areas:
ClientCertificateswere made, now that they are per-request they potentially need the tenant set at the request-level and not just the app-levelClientAssertioninstance was first createdThis PR fixes both issues and generally improves the parts of the codebase where these assertions are used:
ClientAssertionandClientCredentialFactoryto properly call the callback whenever the assertion is neededTokenRequestExecutorto optionally use the tenant from the request to create assertions, and refactors several methods to be simpler and more manageableAuthorityto help with overriding the tenant in an authorityClientCertificateTestandClientCertificateTestto cover the new behavior and fill some gapsThis branch was based off the one in #986, so it must be handled first.