Bind to Only Loopback Address(es) When Making Interactive Request #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g InetSocketAddress(port) which is using wildcard address, so it will attempt to bind to all available network interfaces that includes private IP like 192.168.x.x, 10.x.x.x, etc; which in turns, may/will trigger the firewall prompt. Signed-off-by: riasat <11375716+crimsonvspurple@users.noreply.github.com>
crimsonvspurple
changed the title
crimsonvspurple
changed the title
Avery-Dunn
approved these changes
Mar 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are creating Socket using InetSocketAddress(port) which is using wildcard address, so it will attempt to bind to all available network interfaces that includes private IP like 192.168.x.x, 10.x.x.x, etc; which in turns, may/will trigger the firewall prompt.
In this commit, we explicitly bind to loopback addresses only which will not trigger firewall.