Skip to content

Relax portalocker pin #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

dhirschfeld
Copy link

@dhirschfeld dhirschfeld commented Aug 20, 2021

@dhirschfeld
Copy link
Author

Thought I'd see what the CI thought of this change...

@rayluo rayluo added the enhancement New feature or request label Aug 20, 2021
@dhirschfeld
Copy link
Author

So, it looks like this is failing on py27 as it's installing portalocker-2.3.0

I'm not a pip expert (as I use mamba) but it appears that portalocker is missing a python-requires:

The classifiers imply it works on any Python >=3.3 but I think the correct way to prevent pip from installing version 2.3.0 alongside py27 is to specify python_requires='>=3.3'. Failing that restriction in the upstream repo we'd have to specify that here.

Packaging is hard! 🥴

@rayluo
Copy link
Contributor

rayluo commented Aug 21, 2021

The classifiers imply it works on any Python >=3.3

The classifiers even incorrectly included Python 2, until I send out a PR there, which got merged in 6 hours ago. :-)

but I think the correct way to prevent pip from installing version 2.3.0 alongside py27 is to specify python_requires='>=3.3'.

Thanks for the hint. I also send out another PR there.

Failing that restriction in the upstream repo we'd have to specify that here.

This is also true. And we can probably do it by Environment Markers. Not sure whether we can chain multiple markers, though:

"portalocker~=1.6;platform_system=='Windows';python_version<'3'",
"portalocker>=1.6,<3;platform_system=='Windows';python_version>='3'",

Packaging is hard!

Can't agree more! 🥴

@rayluo rayluo added enhancement New feature or request and removed enhancement New feature or request labels Aug 27, 2021
Co-authored-by: Ray Luo <rayluo.mba@gmail.com>
@rayluo rayluo added enhancement New feature or request and removed enhancement New feature or request labels Aug 27, 2021
@rayluo rayluo closed this in #97 Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mis-specification of portalocker dependency Support portalocker >=2
2 participants