-
Notifications
You must be signed in to change notification settings - Fork 30
Adding explicit unlocking using portalocker #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @abhidnya13 ! Your effort on testing on Mac and founding the significance of that LOCK_NB
flag saves us from a future bugfix!
Co-Authored-By: Ray Luo <rayluo@microsoft.com>
@abhidnya13 @rayluo just to be sure, what happens on Linux if portalocker doesn't have the fix? Will something break, or will it be an issue only in Windows? |
I did not see any issue - I am wondering whether I need to enforce the dependency on Linux or not when uploading the new version to Debian/Ubuntu. |
@bluca If you are using this MSAL Extensions for Python library, it already enforces that dependency (on all platforms, for that matter). If you are using portalocker directly, you can make that decision. You may even open an issue in that repo and hear the input from its author, who is very responsive to github issues. |
No, it doesn't - unless I make it. Hence the question - should it? Is it really necessary for Linux? |
Resolves #42