Skip to content

Adding explicit unlocking using portalocker #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 10, 2020
Merged

Conversation

abhidnya13
Copy link
Contributor

Resolves #42

@abhidnya13 abhidnya13 requested a review from rayluo March 27, 2020 23:27
@abhidnya13
Copy link
Contributor Author

Copy link
Contributor

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @abhidnya13 ! Your effort on testing on Mac and founding the significance of that LOCK_NB flag saves us from a future bugfix!

Co-Authored-By: Ray Luo <rayluo@microsoft.com>
@abhidnya13 abhidnya13 merged commit 5d22932 into dev Apr 10, 2020
@abhidnya13 abhidnya13 deleted the portalocker_fix branch April 10, 2020 20:45
@rayluo rayluo mentioned this pull request Apr 15, 2020
@bluca
Copy link
Contributor

bluca commented Apr 22, 2020

@abhidnya13 @rayluo just to be sure, what happens on Linux if portalocker doesn't have the fix? Will something break, or will it be an issue only in Windows?

@rayluo
Copy link
Contributor

rayluo commented Apr 22, 2020

@bluca According to #42, the specific issue, i.e. lock file is not being deleted, is only reported in Windows.

Did you observe any issue on Linux? If so, what is the symptom? Please create a new issue to describe it.

@bluca
Copy link
Contributor

bluca commented Apr 22, 2020

@bluca According to #42, the specific issue, i.e. lock file is not being deleted, is only reported in Windows.

Did you observe any issue on Linux? If so, what is the symptom? Please create a new issue to describe it.

I did not see any issue - I am wondering whether I need to enforce the dependency on Linux or not when uploading the new version to Debian/Ubuntu.

@rayluo
Copy link
Contributor

rayluo commented Apr 22, 2020

@bluca If you are using this MSAL Extensions for Python library, it already enforces that dependency (on all platforms, for that matter). If you are using portalocker directly, you can make that decision. You may even open an issue in that repo and hear the input from its author, who is very responsive to github issues.

@bluca
Copy link
Contributor

bluca commented Apr 22, 2020

@bluca If you are using this MSAL Extensions for Python library, it already enforces that dependency (on all platforms, for that matter).

No, it doesn't - unless I make it. Hence the question - should it? Is it really necessary for Linux?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The cache lock cannot be removed on Windows 10 if placed inside the user home directory.
5 participants