Improve message for different format value (#304)

* Improve message for different format value

* Update package.json

* Update expandsAllOfFullCoversTest.ts

---------

Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com>

Author: mikekistler

openapi-diff/src/modeler/AutoRest.Swagger/ComparisonMessages.cs

@@ -310,7 +310,7 @@ public static class ComparisonMessages
         {
             Id = 1023,
             Code = nameof(ComparisonMessages.TypeFormatChanged),
-            Message = "The new version has a different format than the previous one.",
+            Message = "The new version has a different format '{0}' than the previous one '{1}'.",
             Type = MessageType.Update
         };
 

openapi-diff/src/modeler/AutoRest.Swagger/Model/SwaggerObject.cs

@@ -42,7 +42,7 @@ public abstract class SwaggerObject<T> : SwaggerBase<T>
         /// Describes the type of additional properties in the data type.
         /// </summary>
         public virtual Schema AdditionalProperties { get; set; }
-        
+
         public virtual string Description { get; set; }
 
         /// <summary>
@@ -136,7 +136,7 @@ T previous
 
             if ((Type.HasValue && prior.Type.HasValue && prior.Type.Value != Type.Value))
             {
-                context.LogError(ComparisonMessages.TypeChanged, 
+                context.LogError(ComparisonMessages.TypeChanged,
                     Type.HasValue ? Type.Value.ToString().ToLower() : "",
                     prior.Type.HasValue ? prior.Type.Value.ToString().ToLower() : "");
             }
@@ -206,7 +206,7 @@ private void CompareEnums(ComparisonContext<ServiceDefinition> context, T prior)
                         context.LogBreakingChange(ComparisonMessages.RemovedEnumValue, String.Join(", ", removedEnums.ToList()));
                     }
                 }
-            
+
                 if (relaxes)
                 {
                     IEnumerable<string> addedEnums = this.Enum.Except(prior.Enum);
@@ -282,11 +282,11 @@ protected void CompareFormats(ComparisonContext<ServiceDefinition> context, T pr
                 throw new ArgumentNullException("context");
             }
 
-            if (prior.Format == null && Format != null || 
+            if (prior.Format == null && Format != null ||
                 prior.Format != null && Format == null ||
                 prior.Format != null && Format != null && !prior.Format.Equals(Format) && !isFormatChangeAllowed(context,prior))
-            {   
-                context.LogBreakingChange(ComparisonMessages.TypeFormatChanged);
+            {
+                context.LogBreakingChange(ComparisonMessages.TypeFormatChanged, Format, prior);
             }
         }
 
@@ -414,8 +414,8 @@ private bool Narrows(string previous, string current, bool isLowerBound)
         {
             int p = 0;
             int c = 0;
-            return int.TryParse(previous, out p) && 
-                   int.TryParse(current, out c) && 
+            return int.TryParse(previous, out p) &&
+                   int.TryParse(current, out c) &&
                    (isLowerBound ? (c > p) : (c < p));
         }
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@azure/oad",
-  "version": "0.10.5",
+  "version": "0.10.6",
   "author": {
     "name": "Microsoft Corporation",
     "email": "azsdkteam@microsoft.com",

src/test/expandsAllOfFullCoversTest.ts

@@ -87,7 +87,7 @@ test("expands allOf full covers", async () => {
     {
       id: "1023",
       code: "TypeFormatChanged",
-      message: "The new version has a different format than the previous one.",
+      message: "The new version has a different format '' than the previous one 'AutoRest.Swagger.Model.Schema'.",
       old: {
         ref: `${oldFilePath}#/definitions/DataBaseProperties/properties/b`,
         path: "definitions.Database.properties.b",