Replace some "import *" (#327)

- Cases where the change is obviously better

Author: mikeharder

src/index.ts

@@ -1,12 +1,9 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
-import * as validate from "./lib/validate"
-
 // Easy to use methods from validate.js
 export { log } from "./lib/util/logging"
-export const compare = validate.compare
-export const compareTags = validate.compareTags
+export { compare, compareTags } from "./lib/validate"
 
 // Classes
 export { OpenApiDiff, Messages, Message, ChangeProperties } from "./lib/validators/openApiDiff"

src/lib/commands/oad.ts

@@ -2,7 +2,7 @@
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 import { log } from "../util/logging"
-import * as validate from "../validate"
+import { compareTags, compare } from "../validate"
 
 export const command = "compare <old-spec> <new-spec>"
 
@@ -47,8 +47,7 @@ export const handler = (argv: Argv) => {
     json: argv.j
   }
 
-  const compareFunc =
-    oldTag && newTag ? validate.compareTags(oldSpec, oldTag, newSpec, newTag, vOptions) : validate.compare(oldSpec, newSpec, vOptions)
+  const compareFunc = oldTag && newTag ? compareTags(oldSpec, oldTag, newSpec, newTag, vOptions) : compare(oldSpec, newSpec, vOptions)
 
   return compareFunc
     .then(result => {

src/lib/validate.ts

@@ -2,7 +2,7 @@
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
 import { log } from "./util/logging"
-import * as OpenApiDiff from "./validators/openApiDiff"
+import { Options, OpenApiDiff } from "./validators/openApiDiff"
 
 /**
  * Wrapper method to compares old and new specifications.
@@ -18,14 +18,14 @@ import * as OpenApiDiff from "./validators/openApiDiff"
  * @param {boolean} [options.matchApiVersion] A boolean flag indicating whether to consider api-version while comparing.
  *
  */
-export function compare(oldSwagger: string, newSwagger: string, options: OpenApiDiff.Options) {
+export function compare(oldSwagger: string, newSwagger: string, options: Options) {
   if (!options) {
     options = {}
   }
 
   log.consoleLogLevel = options.consoleLogLevel || log.consoleLogLevel
   log.filepath = options.logFilepath || log.filepath
-  const openApiDiff = new OpenApiDiff.OpenApiDiff(options)
+  const openApiDiff = new OpenApiDiff(options)
 
   return openApiDiff.compare(oldSwagger, newSwagger)
 }
@@ -48,14 +48,14 @@ export function compare(oldSwagger: string, newSwagger: string, options: OpenApi
  * @param {boolean} [options.matchApiVersion] A boolean flag indicating whether to consider api-version while comparing.
  *
  */
-export function compareTags(oldSwagger: string, oldTag: string, newSwagger: string, newTag: string, options: OpenApiDiff.Options) {
+export function compareTags(oldSwagger: string, oldTag: string, newSwagger: string, newTag: string, options: Options) {
   if (!options) {
     options = {}
   }
 
   log.consoleLogLevel = options.consoleLogLevel || log.consoleLogLevel
   log.filepath = options.logFilepath || log.filepath
-  const openApiDiff = new OpenApiDiff.OpenApiDiff(options)
+  const openApiDiff = new OpenApiDiff(options)
 
   return openApiDiff.compare(oldSwagger, newSwagger, oldTag, newTag)
 }