Remove keyring as a dependency

Author: lmazuel

README.rst

@@ -20,6 +20,16 @@ To install:
 Release History
 ---------------
 
+2018-04-23 Version 0.4.28
++++++++++++++++++++++++++
+
+**Disclaimer**
+
+Do to some stability issues with "keyring" dependency that highly change from one system to another,
+this package is no longer a dependency of this "msrestazure".
+If you were using the secured token cache of `ServicePrincipalCredentials` and `UserPassCredentials`, 
+the feature is still available, but you need to install manually "keyring". The functionnality will activate automatically.
+
 2018-04-18 Version 0.4.27
 +++++++++++++++++++++++++
 

doc/conf.py

@@ -63,9 +63,9 @@
 # built documents.
 #
 # The short X.Y version.
-version = '0.4.27'
+version = '0.4.28'
 # The full version, including alpha/beta/rc tags.
-release = '0.4.27'
+release = '0.4.28'
 
 # The language for content autogenerated by Sphinx. Refer to documentation
 # for a list of supported languages.

msrestazure/azure_active_directory.py

@@ -62,7 +62,7 @@
 _LOGGER = logging.getLogger(__name__)
 
 if not keyring:
-    _LOGGER.warning("Cannot load keyring on your system: %s", KEYRING_EXCEPTION)
+    _LOGGER.warning("Cannot load 'keyring' on your system (even not installed, or not configured correctly): %s", KEYRING_EXCEPTION)
 
 def _build_url(uri, paths, scheme):
     """Combine URL parts.

msrestazure/version.py

@@ -25,4 +25,4 @@
 # --------------------------------------------------------------------------
 
 #: version of the package. Use msrestazure.__version__ instead.
-msrestazure_version = "0.4.27"
+msrestazure_version = "0.4.28"

setup.py

@@ -28,7 +28,7 @@
 
 setup(
     name='msrestazure',
-    version='0.4.27',
+    version='0.4.28',
     author='Microsoft Corporation',
     author_email='azpysdkhelp@microsoft.com',
     packages=find_packages(exclude=["tests", "tests.*"]),
@@ -50,7 +50,6 @@
         'Topic :: Software Development'],
     install_requires=[
         "msrest>=0.4.28,<2.0.0",
-        "keyring>=5.6",
         "adal~=0.5.0"
     ],
 )

tests/test_auth.py

@@ -136,10 +136,12 @@ def test_store_token(self, mock_keyring):
             str({'token_type':'1', 'access_token':'2'}))
 
     @unittest.skipIf(sys.version_info < (3,4), "assertLogs not supported before 3.4")
-    @mock.patch('msrestazure.azure_active_directory.keyring.set_password')
+    @mock.patch('msrestazure.azure_active_directory.keyring')
     def test_store_token_boom(self, mock_keyring):
 
-        mock_keyring.side_effect = Exception('Boom!')
+        def boom(*args, **kwargs):
+            raise Exception("Boom!")
+        mock_keyring.set_password = boom
 
         mix = AADMixin(None, None)
         mix.cred_store = "store_name"