Added decimal type as object #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## smart_obj #225 +/- ##
=============================================
+ Coverage 85.78% 85.83% +0.04%
=============================================
Files 25 25
Lines 2687 2689 +2
=============================================
+ Hits 2305 2308 +3
+ Misses 382 381 -1
Continue to review full report at Codecov.
|
Member
|
Sorry for the late answer, missed it somehow, but the change LGTM. Thanks for the contribution! |
lmazuel
added a commit
that referenced
this pull request
Dec 30, 2020
* Smart serialize of type object * Added decimal type as object (#225) Co-authored-by: Bjerkelund <k.bjerkelund@wilhelmsen.com> Co-authored-by: Kristoffer <43015594+ludokriss@users.noreply.github.com> Co-authored-by: Bjerkelund <k.bjerkelund@wilhelmsen.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added decimal types in addition to the datetime types you have provided.
Don't know if you want me to do this, but thought it wouldn't cost you much to reject if you would like a different implementation.