Inifinite retries on 429 is no longer the default #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@feiskyer @tombuildsstuff PTAL |
catalinaperalta
approved these changes
Feb 19, 2020
feiskyer
approved these changes
Feb 20, 2020
|
Fixes: #322 |
|
Thanks for fixing this. Is there an ETA on when an azure-sdk-for-go will be released with these changes? |
|
@ArcturusZhang can you please update |
Sure, no problem. Is there anything worth mentioning in the README regarding go-autorest v14? |
|
Only real change from v13 to v14 is that 429 (http.StatusTooManyRequests) is no longer infinite retry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.
As part of submitting, please make sure you can make the following assertions:
devbranch, except in the case of urgent bug fixes warranting their own release.master, I've updated CHANGELOG.md to address the changes I'm making.