Skip to content
This repository was archived by the owner on Feb 12, 2025. It is now read-only.

Inifinite retries on 429 is no longer the default#508

Merged
jhendrixMSFT merged 1 commit intoAzure:masterfrom
jhendrixMSFT:infinite429
Feb 24, 2020
Merged

Inifinite retries on 429 is no longer the default#508
jhendrixMSFT merged 1 commit intoAzure:masterfrom
jhendrixMSFT:infinite429

Conversation

@jhendrixMSFT
Copy link
Copy Markdown
Member

Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.

As part of submitting, please make sure you can make the following assertions:

  • I've tested my changes, adding unit tests if applicable.
  • I've added Apache 2.0 Headers to the top of any new source files.
  • I'm submitting this PR to the dev branch, except in the case of urgent bug fixes warranting their own release.
  • If I'm targeting master, I've updated CHANGELOG.md to address the changes I'm making.

@jhendrixMSFT
Copy link
Copy Markdown
Member Author

@feiskyer @tombuildsstuff PTAL

@awesomenix
Copy link
Copy Markdown

Fixes: #322

@jhendrixMSFT jhendrixMSFT merged commit 2368760 into Azure:master Feb 24, 2020
@jhendrixMSFT jhendrixMSFT deleted the infinite429 branch February 24, 2020 17:29
alrs pushed a commit to alrs/go-autorest that referenced this pull request Mar 6, 2020
@fiunchinho
Copy link
Copy Markdown

Thanks for fixing this. Is there an ETA on when an azure-sdk-for-go will be released with these changes?

@jhendrixMSFT
Copy link
Copy Markdown
Member Author

@ArcturusZhang can you please update go-autorest to v14 with the next major release of the SDK?

@ArcturusZhang
Copy link
Copy Markdown
Member

@ArcturusZhang can you please update go-autorest to v14 with the next major release of the SDK?

Sure, no problem. Is there anything worth mentioning in the README regarding go-autorest v14?

@jhendrixMSFT
Copy link
Copy Markdown
Member Author

Only real change from v13 to v14 is that 429 (http.StatusTooManyRequests) is no longer infinite retry.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants