Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Status API updates [Sync changes in RM] #323

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Status API updates [Sync changes in RM] #323

wants to merge 16 commits into from

Conversation

isaac-dasan
Copy link
Member

@isaac-dasan isaac-dasan commented Nov 28, 2018 •
edited
Loading

Description and Motivation

  1. Reduce repetitive code to ping different services by introducing a common 'pingService' method which can be used to ping all the dependencies.
  2. Follows the same contract as RM status APIs. i.e. the Status property will have two properties: isHelathy(bool) and Message(string). This will enable us to report the statuses between different services in a more consistent way.

Change type

  • Bug fix
  • New feature
  • Enhancement
  • Breaking change (breaks backward compatibility)

Checklist:

  • All tests passed
  • The code follows the code style and conventions of this project
  • The change requires a change to the documentation
  • I have updated the documentation accordingly

This change is Reviewable

@isaac-dasan isaac-dasan changed the title Status API updates Status API updates [Let RM team know once this is merged] Nov 29, 2018
@dluc
Copy link
Member

dluc commented Dec 7, 2018

The PR is out of date and needs fixes

@isaac-dasan
Merge remote-tracking branch 'origin/master' into isaac/statusAPI
acfb7e1 
# Conflicts:
#	Services/PreprovisionedIotHub.cs
#	Services/StorageAdapter/StorageAdapterClient.cs
@isaac-dasan isaac-dasan changed the title Status API updates [Let RM team know once this is merged] Status API updates [Sync changes in RM] Feb 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dluc dluc Awaiting requested review from dluc

@hathind-ms hathind-ms Awaiting requested review from hathind-ms

@peterfelts peterfelts Awaiting requested review from peterfelts

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@isaac-dasan @dluc @ppathan @saixiaohui