-
Notifications
You must be signed in to change notification settings - Fork 293
Add support for Open Telemetry #2449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @tommasodotNET for taking up this feature. Added few comments. Also,
|
|
The unit tests were failing due to how the CommandLine library handles parameters in immutable option types. For reference, you can review the details in the following links:
I’ve updated your PR to address the issue and applied the necessary fix. Let me know if you have any questions or need further clarification. |
|
/azp run |
|
/azp run |
abhishekkumams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/azp run |
|
/azp run |
RubenCerna2079
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM



Why make this change?
Initial implementation to add open-telemetry support (reference #2397)
What is this change?
The user can add the open-telemetry configuration in the dab-config.json file as follows:
This configuration can be used alongside the current Application Insights instrumentation, to send logs, traces and metrics to both.
Currently, metrics and traces sent to OTEL comes from AspNetCore and the HttpClients.
The OpenTelemetry implementation only supports dotnet 8.
How was this tested?