Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What If Short Circuiting Linter Rule (Default Off) #14910

Merged
merged 14 commits into from
Sep 10, 2024

Conversation

tsmallig33
Copy link
Contributor

@tsmallig33 tsmallig33 commented Aug 26, 2024

Add what if short circuiting warning when modules do not use deploy time constants for resource Name, Scope, Condition, SubscriptionId, or ResourceGroup

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Aug 26, 2024

Test this change out locally with the following install scripts (Action run 10799726501)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 10799726501
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 10799726501"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 10799726501
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 10799726501"

Copy link
Contributor

github-actions bot commented Aug 26, 2024

Dotnet Test Results

    72 files   -     36      72 suites   - 36   24m 59s ⏱️ - 9m 12s
11 055 tests  -     12  11 055 ✅  -     12  0 💤 ±0  0 ❌ ±0 
25 886 runs   - 12 915  25 886 ✅  - 12 915  0 💤 ±0  0 ❌ ±0 

Results for commit 1fbe570. ± Comparison against base commit 1d71566.

♻️ This comment has been updated with latest results.

@tsmallig33 tsmallig33 marked this pull request as ready for review August 26, 2024 19:57
@tsmallig33 tsmallig33 requested a review from jeskew September 5, 2024 16:01
@tsmallig33 tsmallig33 requested a review from jeskew September 9, 2024 20:43
Copy link
Member

@jeskew jeskew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a couple of minor nitpicks but otherwise LGTM!

src/Bicep.Core/CoreResources.resx Outdated Show resolved Hide resolved
@tsmallig33 tsmallig33 merged commit ead1da2 into main Sep 10, 2024
47 checks passed
@tsmallig33 tsmallig33 deleted the tasmalligan/what-if-linter branch September 10, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants