Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim descriptions in compiled JSON #14870

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Trim descriptions in compiled JSON #14870

merged 1 commit into from
Aug 23, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Aug 22, 2024

Closes #14864

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Aug 22, 2024

Test this change out locally with the following install scripts (Action run 10528981094)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 10528981094
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 10528981094"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 10528981094
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 10528981094"

Copy link
Contributor

github-actions bot commented Aug 22, 2024

Dotnet Test Results

    72 files   -     36      72 suites   - 36   23m 43s ⏱️ - 9m 48s
11 045 tests  -     19  11 045 ✅  -     18  0 💤 ±0  0 ❌  - 1 
25 866 runs   - 12 926  25 866 ✅  - 12 925  0 💤 ±0  0 ❌  - 1 

Results for commit 870298b. ± Comparison against base commit 68f9bca.

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin changed the title Fix to enable description trimming in compiled JSON Trim descriptions in compiled JSON Aug 22, 2024
@anthony-c-martin anthony-c-martin merged commit acb882c into main Aug 23, 2024
47 checks passed
@anthony-c-martin anthony-c-martin deleted the ant/issue14864 branch August 23, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown visualization of description differences
2 participants