Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for issue #14770 #14830

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Fixes for issue #14770 #14830

merged 1 commit into from
Aug 14, 2024

Conversation

anthony-c-martin
Copy link
Member

@anthony-c-martin anthony-c-martin commented Aug 13, 2024

Closes #14770

  • Resolve file system paths for a local extension relative to the bicepconfig.json file
  • Raise diagnostics rather than a fatal exception if an invalid path is specified
Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Test this change out locally with the following install scripts (Action run 10392146656)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 10392146656
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 10392146656"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 10392146656
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 10392146656"

Copy link
Contributor

github-actions bot commented Aug 13, 2024

Dotnet Test Results

    72 files   -     36      72 suites   - 36   22m 37s ⏱️ - 8m 56s
11 039 tests  -     16  11 039 ✅  -     16  0 💤 ±0  0 ❌ ±0 
25 854 runs   - 12 911  25 854 ✅  - 12 911  0 💤 ±0  0 ❌ ±0 

Results for commit aa4c47c. ± Comparison against base commit e40c9fc.

♻️ This comment has been updated with latest results.

@anthony-c-martin anthony-c-martin force-pushed the ant/issue14770 branch 2 times, most recently from 620803c to 215f354 Compare August 14, 2024 04:33
Copy link
Contributor

@shenglol shenglol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local mode bicep - issues noticed
2 participants