Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the aggressive title replacements #973

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Fixed the aggressive title replacements #973

merged 1 commit into from
Sep 11, 2020

Conversation

sima-zhu
Copy link
Contributor

@sima-zhu sima-zhu commented Sep 8, 2020 •
edited
Loading

Fixed the bug of update-doc-metadata.ps1 script which replace the title too aggressively.
Issue: Azure/azure-sdk#1674

Tested in local with python storage pkg.
image
image

@sima-zhu sima-zhu requested a review from scbedd September 8, 2020 23:29
@sima-zhu sima-zhu requested a review from a team as a code owner September 8, 2020 23:29
@sima-zhu sima-zhu self-assigned this Sep 8, 2020
@sima-zhu sima-zhu added the EngSys This issue is impacting the engineering system. label Sep 8, 2020
@sima-zhu sima-zhu requested review from weshaggard and removed request for a team September 8, 2020 23:31
This was referenced Sep 8, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
scbedd
scbedd approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

weshaggard
weshaggard approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets wait until post release to merge.

@sima-zhu
Copy link
Contributor Author

sima-zhu commented Sep 9, 2020

The change is pending for release cycle.

@sima-zhu sima-zhu merged commit 930aa9e into Azure:master Sep 11, 2020
@sima-zhu sima-zhu deleted the update_header_only branch September 11, 2020 21:02
sima-zhu pushed a commit to sima-zhu/azure-sdk-tools that referenced this pull request Dec 3, 2020
@antkmsft
Add support for national cloud auth URLs (Azure#973)
bb1302e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@scbedd scbedd scbedd approved these changes

Assignees

@sima-zhu sima-zhu

Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sima-zhu @weshaggard @scbedd