[AI Foundry Data Management] Enhance .upload_file to accept dataset name and version arguments #40336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomomi-code
requested review from
luigiw,
needuv,
paulshealy1,
singankit,
dargilco and
jhakulin
as code owners
github-actions
bot
added
AI
Community Contribution
|
Thank you for your contribution @tomomi-code! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the upload_file method by introducing new optional parameters and adds error handling for file upload failures.
- Updates the upload_file method signature to include new parameters.
- Modifies the docstring to document these new parameters.
- Implements a try/except block to catch and re-raise exceptions during file upload.
Comments suppressed due to low confidence (3)
sdk/ai/azure-ai-projects/azure/ai/projects/_patch.py:252
- The parameter 'file_name' does not match the PR description which indicates 'dataset_name'. Consider renaming it for consistency.
file_name: str = str(uuid.uuid4()),
sdk/ai/azure-ai-projects/azure/ai/projects/_patch.py:253
- The parameter 'file_version' does not match the PR description which indicates 'dataset_version'. Consider renaming it for consistency.
file_version: str = "1",
sdk/ai/azure-ai-projects/azure/ai/projects/_patch.py:287
- [nitpick] Consider catching more specific exceptions instead of a blanket Exception to avoid inadvertently suppressing unexpected errors.
try:
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
annatisch
removed
customer-reported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a PR for #39901
dataset_nameanddataset_versionto theupload_filemethod.All SDK Contribution checklist:
General Guidelines and Best Practices