Fix Environment Variable Parsing #40303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes environment variable parsing issues by refactoring how environment variable values are accessed and converted, leveraging a new constants file for configuration. Key changes include:
- Updating test files to set and validate environment variables for vector and hybrid search queries.
- Refactoring client connection and execution context files to use constant definitions for environment variable keys and defaults.
- Adding new constants in _constants.py for improved configuration management.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/cosmos/azure-cosmos/tests/test_query_vector_similarity_async.py | Added tests for vector search with environment variable overrides. |
| sdk/cosmos/azure-cosmos/tests/test_query_vector_similarity.py | Added similar vector search tests for synchronous queries. |
| sdk/cosmos/azure-cosmos/tests/test_query_hybrid_search_async.py | Introduced hybrid search tests with environment variable configurations. |
| sdk/cosmos/azure-cosmos/tests/test_query_hybrid_search.py | Added synchronous hybrid search tests using environment variable settings. |
| sdk/cosmos/azure-cosmos/azure/cosmos/aio/_cosmos_client_connection_async.py | Updated environment variable usage to retrieve non-streaming order by flag using constants. |
| sdk/cosmos/azure-cosmos/azure/cosmos/_execution_context/execution_dispatcher.py | Refactored hybrid and vector search environment variable parsing via constants with int conversion. |
| sdk/cosmos/azure-cosmos/azure/cosmos/_execution_context/aio/execution_dispatcher.py | Updated vector search environment variable handling to use constants and int conversion. |
| sdk/cosmos/azure-cosmos/azure/cosmos/_cosmos_client_connection.py | Refactored non-streaming order by environment variable check to use constants. |
| sdk/cosmos/azure-cosmos/azure/cosmos/_constants.py | Added new constants for environment variable keys and their defaults. |
| sdk/cosmos/azure-cosmos/CHANGELOG.md | Updated changelog to document the environment variable parsing fix. |
kushagraThapar
approved these changes
Mar 31, 2025
|
API change check API changes are not detected in this pull request. |
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
simorenoh
approved these changes
Apr 3, 2025
nik1097
pushed a commit
to nik1097/azure-sdk-for-python
that referenced
this pull request
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Environment variables were not being parsed correctly and would cause type errors or unexpected behavior. Refactored the environment variables to be part of the constants file to be easily accessible.