Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Add authorization challenge parsing helper #24979

Closed
wants to merge 1 commit into from

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Jun 24, 2022

Description

Resolves #23613. This is a follow-up to #24019, adjusting to feedback in Azure/azure-sdk#4302. Instead of adding a new policy to handle authorization challenges, this PR follows other languages' lead in providing a helper class for parsing challenges (see .NET's), and leaves the implementation of on_challenge and/or custom on_request methods to BearerTokenCredentialPolicy subclasses.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-core

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Oct 21, 2022
@ghost
Copy link

ghost commented Oct 21, 2022

Hi @mccoyp. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Oct 29, 2022
@ghost
Copy link

ghost commented Oct 29, 2022

Hi @mccoyp. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core no-recent-activity There has been no recent activity on this issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move multi-tenant authentication-supporting code into azure-core
2 participants