-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Refactor AzureJSONEncoder #21028
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
fb50ae9
Refactor AzureJSONEncoder
Codejune e68b8d8
Improved readability of AzureJSONEncoder datetime handling
Codejune efe1af8
Add some docstring
Codejune 76fc86e
Fix typo and add type checking
Codejune 065e4f2
Improve type checking and rename some inner variables
Codejune File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mypy error:
error: Item "date" of "Union[datetime, date, time, timedelta]" has no attribute "tzinfo"
error: Item "timedelta" of "Union[datetime, date, time, timedelta]" has no attribute "tzinfo"
error: Item "timedelta" of "Union[datetime, date, time, timedelta]" has no attribute "replace"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering what the best way to resolve these would be... maybe
cast
ing to the type we know it should be at each point? e.g. in this case,There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should check using typing.Newtype() for datetime, date, time, and timedelta. Something like
This method passed
tox -e mypy -c ../../../eng/tox/tox.ini
.But it looks like hardcoded. So I'm thinking of a better way to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typing.NewType is introduced in python 3, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It was added in Python 3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, we need to support 2.7 as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. By previous comments I have know that the sdk should support python 2.7.
So I didn't committed this method yet. But your suggestions are helping me a lot. Thank you. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about not using
typing.NewType
? As follows.It passed all my local
tox
tests.However, I haven't tested it against Python 2.7 yet.
And I wonder if there are side effects caused by removing the
if TYPE_CHECKING:
check.So I need to test it with Azure Pipeline.
How do you think of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is too much for a developer to test all the combinations, so we setup the pipeline. :)
Feel free to leverage the pipeline to test py2.7.
We don't encourage removing type checking because sometimes it does find real issues. Does this make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! :)
I'll add a commit on this soon and check it out.
Thank you for your time!