Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove implicit dependency on successful completion of verify-links #18277

Merged
merged 4 commits into from
May 18, 2021

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Apr 24, 2021

It's an eng/common/scripts which uses a specific function from within LanguageSettings.ps1.

That specific function actually needs packaging to be installed. This happens in analyze_deps.py, so we simply move this below it without burning any more time on installation.

@scbedd scbedd changed the title move verify-links directly into analyze.yml Remove implicit dependency on successful completion of verify-links Apr 29, 2021
@scbedd scbedd merged commit ab0e47a into Azure:master May 18, 2021
iscai-msft added a commit to agniveshadhikari/azure-sdk-for-python that referenced this pull request May 18, 2021
…into agrifood/test-infra

* 'master' of https://github.com/Azure/azure-sdk-for-python: (33 commits)
  Increment version for textanalytics releases (Azure#18797)
  remove PHI with multiple actions due to known service error (Azure#18794)
  [textanalyitcs] switch to westus2 region (Azure#18791)
  Remove implicit dependency on successful completion of verify-links (Azure#18277)
  Add Testing of Conda Artifacts (Azure#18478)
  reset continuation token (Azure#18772)
  pipline prepare (Azure#18755)
  [AutoRelease] t2-machinelearningcompute-2021-05-14-14426(wave4) (Azure#18750)
  [AutoRelease] t2-iothubprovisioningservices-2021-05-14-29542(wave4) (Azure#18748)
  [AutoRelease] t2-agfood-2021-05-17-53436 (Azure#18768)
  unskip custom form tests - unlabeled table bounding box regression fixed (Azure#18776)
  [Tables] test cleanup (Azure#18676)
  adding mindependency to the default set of PR tests (Azure#18775)
  updating sample for beta2 api (Azure#18711)
  useless folder del (Azure#18771)
  [AutoRelease] t2-recoveryservicesbackup-2021-05-14-03506(wave4) (Azure#18749)
  [AutoRelease] t2-network-2021-05-14-21408(Do not merge) (Azure#18746)
  [AutoRelease] t2-iothub-2021-05-14-97452 (Azure#18753)
  Rename to AZURE_PHONE_NUMBER (Azure#18760)
  [Communication]: Removed tests.yml file for single pipeline (Azure#18684)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request May 28, 2021
…into protocol_base

* 'master' of https://github.com/Azure/azure-sdk-for-python: (365 commits)
  Agrifood/test infra (Azure#18779)
  [formrecognizer] update samples to train a model where a model_id is needed (Azure#18789)
  replace response urls too (Azure#18758)
  [AutoRelease] t2-resource-2021-05-19-78417 (Azure#18807)
  [pipeline]update autorest version for pipeline (Azure#18782)
  [AutoRelease] t2-digitaltwins-2021-05-18-25594(wave4) (Azure#18786)
  [AutoRelease] t2-hybridkubernetes-2021-05-19-49364(wave4) (Azure#18802)
  Added Async APIs and Samples for attestation SDK (Azure#18735)
  [AVA] Updating links in package ReadMe (Azure#18800)
  Sync eng/common directory with azure-sdk-tools for PR 1585 (Azure#18793)
  Increment version for textanalytics releases (Azure#18797)
  remove PHI with multiple actions due to known service error (Azure#18794)
  [textanalyitcs] switch to westus2 region (Azure#18791)
  Remove implicit dependency on successful completion of verify-links (Azure#18277)
  Add Testing of Conda Artifacts (Azure#18478)
  reset continuation token (Azure#18772)
  pipline prepare (Azure#18755)
  [AutoRelease] t2-machinelearningcompute-2021-05-14-14426(wave4) (Azure#18750)
  [AutoRelease] t2-iothubprovisioningservices-2021-05-14-29542(wave4) (Azure#18748)
  [AutoRelease] t2-agfood-2021-05-17-53436 (Azure#18768)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants